mirror of
https://github.com/google/bumble.git
synced 2026-04-16 00:25:31 +00:00
address PR comments
This commit is contained in:
@@ -3750,7 +3750,7 @@ class Device(utils.CompositeEventEmitter):
|
|||||||
if self.is_le_connecting:
|
if self.is_le_connecting:
|
||||||
raise InvalidStateError('connection already pending')
|
raise InvalidStateError('connection already pending')
|
||||||
|
|
||||||
try_resolve = True
|
try_resolve = not self.address_resolution_offload
|
||||||
if isinstance(peer_address, str):
|
if isinstance(peer_address, str):
|
||||||
try:
|
try:
|
||||||
peer_address = hci.Address.from_string_for_transport(
|
peer_address = hci.Address.from_string_for_transport(
|
||||||
@@ -4073,10 +4073,6 @@ class Device(utils.CompositeEventEmitter):
|
|||||||
[deprecated] (ignore)
|
[deprecated] (ignore)
|
||||||
'''
|
'''
|
||||||
|
|
||||||
# Check parameters
|
|
||||||
if transport not in (PhysicalTransport.LE, PhysicalTransport.BR_EDR):
|
|
||||||
raise InvalidArgumentError('invalid transport')
|
|
||||||
|
|
||||||
# Connect using the appropriate transport
|
# Connect using the appropriate transport
|
||||||
# (auto-correct the transport based on declared capabilities)
|
# (auto-correct the transport based on declared capabilities)
|
||||||
if transport == PhysicalTransport.LE or (
|
if transport == PhysicalTransport.LE or (
|
||||||
@@ -4088,14 +4084,15 @@ class Device(utils.CompositeEventEmitter):
|
|||||||
own_address_type=own_address_type,
|
own_address_type=own_address_type,
|
||||||
timeout=timeout,
|
timeout=timeout,
|
||||||
)
|
)
|
||||||
elif transport == PhysicalTransport.BR_EDR or (
|
|
||||||
|
if transport == PhysicalTransport.BR_EDR or (
|
||||||
self.classic_enabled and not self.le_enabled
|
self.classic_enabled and not self.le_enabled
|
||||||
):
|
):
|
||||||
return await self.connect_classic(
|
return await self.connect_classic(
|
||||||
peer_address=peer_address, timeout=timeout
|
peer_address=peer_address, timeout=timeout
|
||||||
)
|
)
|
||||||
else:
|
|
||||||
raise InvalidArgumentError('no supported transport for request')
|
raise ValueError('invalid transport')
|
||||||
|
|
||||||
async def accept(
|
async def accept(
|
||||||
self,
|
self,
|
||||||
|
|||||||
Reference in New Issue
Block a user