auracaster/bumble_mirror
3
0
Fork 1
mirror of https://github.com/google/bumble.git synced 2026-05-09 04:08:02 +00:00
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #579 from jmdietrich-gcx/unsubscribe_characteristic_in_gatt_client

Browse Source 
Remove characteristic in GATT Client unsubscribe() if it's the last subscriber
This commit is contained in:
Gilles Boccon-Gibod
2024-10-31 04:07:02 -07:00
committed by GitHub
parent c4e9726828 73fe564321
commit b78f895143
1 changed files with 6 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
bumble/gatt_client.py
View File

@@ -898,6 +898,12 @@ class Client:
) and subscriber in subscribers: ) and subscriber in subscribers:
subscribers.remove(subscriber) subscribers.remove(subscriber)
# The characteristic itself is added as subscriber. If it is the
# last remaining subscriber, we remove it, such that the clean up
# works correctly. Otherwise the CCCD never is set back to 0.
if len(subscribers) == 1 and characteristic in subscribers:
subscribers.remove(characteristic)
# Cleanup if we removed the last one # Cleanup if we removed the last one
if not subscribers: if not subscribers:
del subscriber_set[characteristic.handle] del subscriber_set[characteristic.handle]