diff --git a/bumble/device.py b/bumble/device.py index ce49fb9..4b3fa43 100644 --- a/bumble/device.py +++ b/bumble/device.py @@ -1211,11 +1211,15 @@ class Device(CompositeEventEmitter): if type(peer_address) is str: try: - peer_address = Address(peer_address) + peer_address = Address.from_string_for_transport(peer_address, transport) except ValueError: # If the address is not parsable, assume it is a name instead logger.debug('looking for peer by name') peer_address = await self.find_peer_by_name(peer_address, transport) # TODO: timeout + else: + # All BR/EDR addresses should be public addresses + if transport == BT_BR_EDR_TRANSPORT and peer_address.address_type != Address.PUBLIC_DEVICE_ADDRESS: + raise ValueError('BR/EDR addresses must be PUBLIC') def on_connection(connection): if transport == BT_LE_TRANSPORT or ( diff --git a/bumble/hci.py b/bumble/hci.py index cf9f682..1527c92 100644 --- a/bumble/hci.py +++ b/bumble/hci.py @@ -1666,6 +1666,14 @@ class Address: def address_type_name(address_type): return name_or_number(Address.ADDRESS_TYPE_NAMES, address_type) + @staticmethod + def from_string_for_transport(string, transport): + if transport == BT_BR_EDR_TRANSPORT: + address_type = Address.PUBLIC_DEVICE_ADDRESS + else: + address_type = Address.RANDOM_DEVICE_ADDRESS + return Address(string, address_type) + @staticmethod def parse_address(data, offset): # Fix the type to a default value. This is used for parsing type-less Classic addresses @@ -1706,6 +1714,9 @@ class Address: self.address_type = address_type + def clone(self): + return Address(self.address_bytes, self.address_type) + @property def is_public(self): return self.address_type == self.PUBLIC_DEVICE_ADDRESS or self.address_type == self.PUBLIC_IDENTITY_ADDRESS