auracaster/openocd
3
0
Fork 1
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

transport: fix incorrect statement

Browse Source 
Commit 236208a5ff ("transport: use a bitmask for the transport")
has an incorrect C statement in place of a return.
The code is working thanks to the previous condition never true.

The issue has been detected by clang scan-build in OpenOCD ACI
since the missing return can make the following statement
dereferencing a NULL pointer.

Fix it!

Change-Id: I3bbe04d99ad9b1288f55ba3c45e2e487aef9ae40
Signed-off-by: Antonio Borneo <borneo.antonio@gmail.com>
Fixes: 236208a5ff ("transport: use a bitmask for the transport")
Reviewed-on: https://review.openocd.org/c/openocd/+/8868
Tested-by: jenkins
This commit is contained in:
Antonio Borneo
2025-05-01 19:38:42 +02:00
parent 06c827757b
commit 00f5b7ece6
1 changed files with 1 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
src/transport/transport.c
View File

@@ -258,7 +258,7 @@ struct transport *get_current_transport(void)
const char *get_current_transport_name(void) const char *get_current_transport_name(void)
{ {
if (!session || !is_transport_id_valid(session->id)) if (!session || !is_transport_id_valid(session->id))
NULL; return NULL;
return transport_full_name(session->id); return transport_full_name(session->id);
} }