auracaster/openocd
3
0
Fork 1
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

binarybuffer: Remove unnecessary cast and fix hidden "bug"

Browse Source 
Because of the cast, the const decoration on the parameter provided no
guarantee against modification since it was silently discarded.

Change-Id: Ib83ade955e1a61ee2175c690620437b5e19cbb6a
Signed-off-by: Andreas Fritiofson <andreas.fritiofson@gmail.com>
Reviewed-on: http://openocd.zylin.com/1776
Tested-by: jenkins
Reviewed-by: Spencer Oliver <spen@spen-soft.co.uk>
This commit is contained in:
Andreas Fritiofson
2013-09-28 23:01:07 +02:00
committed by Spencer Oliver
parent 4935709484
commit 01298ca2c8
2 changed files with 6 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
src/helper/binarybuffer.c
View File

@@ -148,7 +148,7 @@ void *buf_set_buf(const void *_src, unsigned src_start,
if ((sq == 0) && (dq == 0) && (lq == 0)) {
for (i = 0; i < lb; i++)
*dst++ = *src++;
return (uint8_t *)_dst;
return _dst;
}
/* fallback to slow bit copy */
@@ -167,7 +167,7 @@ void *buf_set_buf(const void *_src, unsigned src_start,
}
}
return (uint8_t *)_dst;
return _dst;
}
uint32_t flip_u32(uint32_t value, unsigned int num)