From 0e41ac862d3280fa2fb948ba4dbf74d52cb25966 Mon Sep 17 00:00:00 2001 From: Mark O'Donovan Date: Tue, 24 Feb 2026 20:44:43 +0000 Subject: [PATCH] pld/gatemate: move pointer deref after NULL check Move pointer deref after NULL check. Found by cppcheck. Change-Id: Ifdf40046cb1b03dbe7f445660b3349deae788e7b Signed-off-by: Mark O'Donovan Reviewed-on: https://review.openocd.org/c/openocd/+/9499 Reviewed-by: Daniel Anselmi Reviewed-by: Antonio Borneo Tested-by: jenkins --- src/pld/gatemate.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/pld/gatemate.c b/src/pld/gatemate.c index f35b39ad2..479f6d183 100644 --- a/src/pld/gatemate.c +++ b/src/pld/gatemate.c @@ -138,11 +138,11 @@ static int gatemate_read_cfg_file(struct gatemate_bit_file *bit_file, const char static int gatemate_read_file(struct gatemate_bit_file *bit_file, const char *filename) { - memset(bit_file, 0, sizeof(struct gatemate_bit_file)); - if (!filename || !bit_file) return ERROR_COMMAND_SYNTAX_ERROR; + memset(bit_file, 0, sizeof(struct gatemate_bit_file)); + /* check if binary .bit or ascii .cfg */ const char *file_suffix_pos = strrchr(filename, '.'); if (!file_suffix_pos) {