Change return value on error.
On wrong parameters a error is signalized to the calling function. Change-Id: I484443fdb39938e20382edc9246d5ec546a5c960 Signed-off-by: Mathias K <kesmtp@freenet.de> Signed-off-by: Øyvind Harboe <oyvind.harboe@zylin.com> Reviewed-on: http://openocd.zylin.com/282 Tested-by: jenkins Reviewed-by: Øyvind Harboe <oyvindharboe@gmail.com>
This commit is contained in:
+2
-4
@@ -63,8 +63,7 @@ COMMAND_HANDLER(handle_pld_device_command)
|
||||
|
||||
if (CMD_ARGC < 1)
|
||||
{
|
||||
LOG_WARNING("incomplete 'pld device' command");
|
||||
return ERROR_OK;
|
||||
return ERROR_COMMAND_SYNTAX_ERROR;
|
||||
}
|
||||
|
||||
for (i = 0; pld_drivers[i]; i++)
|
||||
@@ -155,8 +154,7 @@ COMMAND_HANDLER(handle_pld_load_command)
|
||||
|
||||
if (CMD_ARGC < 2)
|
||||
{
|
||||
command_print(CMD_CTX, "usage: pld load <device#> <file>");
|
||||
return ERROR_OK;
|
||||
return ERROR_COMMAND_SYNTAX_ERROR;
|
||||
}
|
||||
|
||||
unsigned dev_id;
|
||||
|
||||
+2
-4
@@ -179,8 +179,7 @@ COMMAND_HANDLER(virtex2_handle_read_stat_command)
|
||||
|
||||
if (CMD_ARGC < 1)
|
||||
{
|
||||
command_print(CMD_CTX, "usage: virtex2 read_stat <num>");
|
||||
return ERROR_OK;
|
||||
return ERROR_COMMAND_SYNTAX_ERROR;
|
||||
}
|
||||
|
||||
unsigned dev_id;
|
||||
@@ -207,8 +206,7 @@ PLD_DEVICE_COMMAND_HANDLER(virtex2_pld_device_command)
|
||||
|
||||
if (CMD_ARGC < 2)
|
||||
{
|
||||
LOG_WARNING("incomplete pld device 'virtex2' configuration");
|
||||
return ERROR_PLD_DEVICE_INVALID;
|
||||
return ERROR_COMMAND_SYNTAX_ERROR;
|
||||
}
|
||||
|
||||
tap = jtag_tap_by_string(CMD_ARGV[1]);
|
||||
|
||||
Reference in New Issue
Block a user