openocd: fix simple cases of Yoda condition
There are ~900 Yoda conditions to be aligned to the coding style.
For recurrent Yoda conditions it's preferable using a trivial
script in order to minimize the review effort.
E.g. comparison of uppercase macro/enum with lowercase variable:
- ...(ERROR_OK == retval)...
+ ...(retval == ERROR_OK)...
Patch generated automatically with the command:
sed -i \
's/(\([A-Z][A-Z0-9_]*\) \([=!]=\) \([a-z][a-z0-9_]*\))/(\3 \2 \1)/g' \
$(find src/ -type f)
While there, remove the braces {} around a single statement block
to prevent warning from checkpatch.
Change-Id: If585b0a4b4578879c87b2dd74d9e0025e275ec6b
Signed-off-by: Antonio Borneo <borneo.antonio@gmail.com>
Reviewed-on: http://openocd.zylin.com/6354
Tested-by: jenkins
Reviewed-by: Xiang W <wxjstz@126.com>
This commit is contained in:
@@ -103,7 +103,7 @@ static int jsp_new_connection(struct connection *connection)
|
||||
|
||||
int retval = target_register_timer_callback(&jsp_poll_read, 1,
|
||||
TARGET_TIMER_TYPE_PERIODIC, jsp_service);
|
||||
if (ERROR_OK != retval)
|
||||
if (retval != ERROR_OK)
|
||||
return retval;
|
||||
|
||||
return ERROR_OK;
|
||||
@@ -187,7 +187,7 @@ static int jsp_connection_closed(struct connection *connection)
|
||||
struct jsp_service *jsp_service = connection->service->priv;
|
||||
|
||||
int retval = target_unregister_timer_callback(&jsp_poll_read, jsp_service);
|
||||
if (ERROR_OK != retval)
|
||||
if (retval != ERROR_OK)
|
||||
return retval;
|
||||
|
||||
free(connection->priv);
|
||||
|
||||
Reference in New Issue
Block a user