auracaster/openocd
3
0
Fork 1
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

jtag: cut down on usage of unintended modification of global end state

Browse Source 
jtag_get/set_end_state() is now deprecated.

There were lots of places in the code where the end state was
unintentionally modified.

The big Q is whether there were any places where the intention
was to modify the end state. 0.5 is a long way off, so we'll
get a fair amount of testing.

Signed-off-by: Øyvind Harboe <oyvind.harboe@zylin.com>
This commit is contained in:
Øyvind Harboe
2010-03-16 14:13:03 +01:00
parent fccdfc1cd7
commit 36df240cea
24 changed files with 4062 additions and 99 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
src/jtag/core.c
View File

@@ -743,7 +743,8 @@ void jtag_add_reset(int req_tlr_or_trst, int req_srst)
}
}
tap_state_t jtag_set_end_state(tap_state_t state)
/* DEPRECATED! store such global state outside JTAG layer */
void jtag_set_end_state(tap_state_t state)
{
if ((state == TAP_DRSHIFT)||(state == TAP_IRSHIFT))
{
@@ -752,9 +753,9 @@ tap_state_t jtag_set_end_state(tap_state_t state)
if (state != TAP_INVALID)
cmd_queue_end_state = state;
return cmd_queue_end_state;
}
/* DEPRECATED! store such global state outside JTAG layer */
tap_state_t jtag_get_end_state(void)
{
return cmd_queue_end_state;

7
src/jtag/jtag.h
View File

@@ -552,15 +552,18 @@ void jtag_add_reset(int req_tlr_or_trst, int srst);
/**
* DEPRECATED! store such global state outside JTAG layer
*
* Function jtag_set_end_state
*
* Set a global variable to \a state if \a state != TAP_INVALID.
*
* Return the value of the global variable.
*/
tap_state_t jtag_set_end_state(tap_state_t state);
void jtag_set_end_state(tap_state_t state);
/**
* DEPRECATED! store such global state outside JTAG layer
*
* Function jtag_get_end_state
*
* Return the value of the global variable for end state