jtag: cut down on usage of unintended modification of global end state
jtag_get/set_end_state() is now deprecated. There were lots of places in the code where the end state was unintentionally modified. The big Q is whether there were any places where the intention was to modify the end state. 0.5 is a long way off, so we'll get a fair amount of testing. Signed-off-by: Øyvind Harboe <oyvind.harboe@zylin.com>
This commit is contained in:
@@ -482,9 +482,9 @@ COMMAND_HANDLER(handle_xsvf_command)
|
||||
|
||||
if (tap == NULL)
|
||||
jtag_add_plain_dr_scan(field.num_bits, field.out_value, field.in_value,
|
||||
jtag_set_end_state(TAP_DRPAUSE));
|
||||
TAP_DRPAUSE);
|
||||
else
|
||||
jtag_add_dr_scan(tap, 1, &field, jtag_set_end_state(TAP_DRPAUSE));
|
||||
jtag_add_dr_scan(tap, 1, &field, TAP_DRPAUSE);
|
||||
|
||||
jtag_check_value_mask(&field, dr_in_buf, dr_in_mask);
|
||||
|
||||
@@ -939,9 +939,9 @@ COMMAND_HANDLER(handle_xsvf_command)
|
||||
|
||||
if (tap == NULL)
|
||||
jtag_add_plain_dr_scan(field.num_bits, field.out_value, field.in_value,
|
||||
jtag_set_end_state(TAP_DRPAUSE));
|
||||
TAP_DRPAUSE);
|
||||
else
|
||||
jtag_add_dr_scan(tap, 1, &field, jtag_set_end_state(TAP_DRPAUSE));
|
||||
jtag_add_dr_scan(tap, 1, &field, TAP_DRPAUSE);
|
||||
|
||||
jtag_check_value_mask(&field, dr_in_buf, dr_in_mask);
|
||||
|
||||
|
||||
Reference in New Issue
Block a user