openocd: remove NULL comparisons with checkpatch [1/2]
Patch generated automatically through the new checkpatch with flags "--types COMPARISON_TO_NULL --fix-inplace". This only fixes the comparisons if (symbol == NULL) if (symbol != NULL) The case of NULL on the left side of the comparison is not tested. Some automatic fix is incorrect and has been massaged by hands: - if (*psig == NULL) + if (*!psig) changed as + if (!*psig) Change-Id: If4a1e2b4e547e223532e8e3d9da89bf9cb382ce6 Signed-off-by: Antonio Borneo <borneo.antonio@gmail.com> Reviewed-on: http://openocd.zylin.com/6351 Tested-by: jenkins
This commit is contained in:
@@ -24,7 +24,7 @@
|
||||
|
||||
int aice_read_reg_64(struct aice_port_s *aice, uint32_t num, uint64_t *val)
|
||||
{
|
||||
if (aice->port->api->read_reg_64 == NULL) {
|
||||
if (!aice->port->api->read_reg_64) {
|
||||
LOG_WARNING("Not implemented: %s", __func__);
|
||||
return ERROR_FAIL;
|
||||
}
|
||||
@@ -34,7 +34,7 @@ int aice_read_reg_64(struct aice_port_s *aice, uint32_t num, uint64_t *val)
|
||||
|
||||
int aice_write_reg_64(struct aice_port_s *aice, uint32_t num, uint64_t val)
|
||||
{
|
||||
if (aice->port->api->write_reg_64 == NULL) {
|
||||
if (!aice->port->api->write_reg_64) {
|
||||
LOG_WARNING("Not implemented: %s", __func__);
|
||||
return ERROR_FAIL;
|
||||
}
|
||||
@@ -45,7 +45,7 @@ int aice_write_reg_64(struct aice_port_s *aice, uint32_t num, uint64_t val)
|
||||
int aice_read_tlb(struct aice_port_s *aice, target_addr_t virtual_address,
|
||||
target_addr_t *physical_address)
|
||||
{
|
||||
if (aice->port->api->read_tlb == NULL) {
|
||||
if (!aice->port->api->read_tlb) {
|
||||
LOG_WARNING("Not implemented: %s", __func__);
|
||||
return ERROR_FAIL;
|
||||
}
|
||||
@@ -55,7 +55,7 @@ int aice_read_tlb(struct aice_port_s *aice, target_addr_t virtual_address,
|
||||
|
||||
int aice_cache_ctl(struct aice_port_s *aice, uint32_t subtype, uint32_t address)
|
||||
{
|
||||
if (aice->port->api->cache_ctl == NULL) {
|
||||
if (!aice->port->api->cache_ctl) {
|
||||
LOG_WARNING("Not implemented: %s", __func__);
|
||||
return ERROR_FAIL;
|
||||
}
|
||||
@@ -65,7 +65,7 @@ int aice_cache_ctl(struct aice_port_s *aice, uint32_t subtype, uint32_t address)
|
||||
|
||||
int aice_set_retry_times(struct aice_port_s *aice, uint32_t a_retry_times)
|
||||
{
|
||||
if (aice->port->api->set_retry_times == NULL) {
|
||||
if (!aice->port->api->set_retry_times) {
|
||||
LOG_WARNING("Not implemented: %s", __func__);
|
||||
return ERROR_FAIL;
|
||||
}
|
||||
@@ -75,7 +75,7 @@ int aice_set_retry_times(struct aice_port_s *aice, uint32_t a_retry_times)
|
||||
|
||||
int aice_program_edm(struct aice_port_s *aice, char *command_sequence)
|
||||
{
|
||||
if (aice->port->api->program_edm == NULL) {
|
||||
if (!aice->port->api->program_edm) {
|
||||
LOG_WARNING("Not implemented: %s", __func__);
|
||||
return ERROR_FAIL;
|
||||
}
|
||||
@@ -86,7 +86,7 @@ int aice_program_edm(struct aice_port_s *aice, char *command_sequence)
|
||||
int aice_set_command_mode(struct aice_port_s *aice,
|
||||
enum aice_command_mode command_mode)
|
||||
{
|
||||
if (aice->port->api->set_command_mode == NULL) {
|
||||
if (!aice->port->api->set_command_mode) {
|
||||
LOG_WARNING("Not implemented: %s", __func__);
|
||||
return ERROR_FAIL;
|
||||
}
|
||||
@@ -97,7 +97,7 @@ int aice_set_command_mode(struct aice_port_s *aice,
|
||||
int aice_execute(struct aice_port_s *aice, uint32_t *instructions,
|
||||
uint32_t instruction_num)
|
||||
{
|
||||
if (aice->port->api->execute == NULL) {
|
||||
if (!aice->port->api->execute) {
|
||||
LOG_WARNING("Not implemented: %s", __func__);
|
||||
return ERROR_FAIL;
|
||||
}
|
||||
@@ -107,7 +107,7 @@ int aice_execute(struct aice_port_s *aice, uint32_t *instructions,
|
||||
|
||||
int aice_set_custom_srst_script(struct aice_port_s *aice, const char *script)
|
||||
{
|
||||
if (aice->port->api->set_custom_srst_script == NULL) {
|
||||
if (!aice->port->api->set_custom_srst_script) {
|
||||
LOG_WARNING("Not implemented: %s", __func__);
|
||||
return ERROR_FAIL;
|
||||
}
|
||||
@@ -117,7 +117,7 @@ int aice_set_custom_srst_script(struct aice_port_s *aice, const char *script)
|
||||
|
||||
int aice_set_custom_trst_script(struct aice_port_s *aice, const char *script)
|
||||
{
|
||||
if (aice->port->api->set_custom_trst_script == NULL) {
|
||||
if (!aice->port->api->set_custom_trst_script) {
|
||||
LOG_WARNING("Not implemented: %s", __func__);
|
||||
return ERROR_FAIL;
|
||||
}
|
||||
@@ -127,7 +127,7 @@ int aice_set_custom_trst_script(struct aice_port_s *aice, const char *script)
|
||||
|
||||
int aice_set_custom_restart_script(struct aice_port_s *aice, const char *script)
|
||||
{
|
||||
if (aice->port->api->set_custom_restart_script == NULL) {
|
||||
if (!aice->port->api->set_custom_restart_script) {
|
||||
LOG_WARNING("Not implemented: %s", __func__);
|
||||
return ERROR_FAIL;
|
||||
}
|
||||
@@ -137,7 +137,7 @@ int aice_set_custom_restart_script(struct aice_port_s *aice, const char *script)
|
||||
|
||||
int aice_set_count_to_check_dbger(struct aice_port_s *aice, uint32_t count_to_check)
|
||||
{
|
||||
if (aice->port->api->set_count_to_check_dbger == NULL) {
|
||||
if (!aice->port->api->set_count_to_check_dbger) {
|
||||
LOG_WARNING("Not implemented: %s", __func__);
|
||||
return ERROR_FAIL;
|
||||
}
|
||||
@@ -148,7 +148,7 @@ int aice_set_count_to_check_dbger(struct aice_port_s *aice, uint32_t count_to_ch
|
||||
int aice_profiling(struct aice_port_s *aice, uint32_t interval, uint32_t iteration,
|
||||
uint32_t reg_no, uint32_t *samples, uint32_t *num_samples)
|
||||
{
|
||||
if (aice->port->api->profiling == NULL) {
|
||||
if (!aice->port->api->profiling) {
|
||||
LOG_WARNING("Not implemented: %s", __func__);
|
||||
return ERROR_FAIL;
|
||||
}
|
||||
|
||||
Reference in New Issue
Block a user