auracaster/openocd
3
0
Fork 1
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

use COMMAND_PARSE_ENABLE macro where appropriate

Browse Source 
Updates all command parsing of simple "enable" and "disable" arguments.
A few case in the tree use a tri-state or extended arguments, which
cannot use this simple macro.

Simlifies the xscale icache/dcache command handler logic.
This commit is contained in:
Zachary T Welch
2009-11-18 05:36:18 -08:00
parent 75a37eb5b3
commit 410fab9ea8
6 changed files with 41 additions and 158 deletions
Download Patch File Download Diff File Expand all files Collapse all files

21
src/target/etm.c
View File

@@ -1214,25 +1214,14 @@ static COMMAND_HELPER(handle_etm_tracemode_command_update,
return ERROR_INVALID_ARGUMENTS;
}
if (strcmp(CMD_ARGV[2], "enable") == 0)
bool etmv1_cycle_accurate;
COMMAND_PARSE_ENABLE(CMD_ARGV[2], etmv1_cycle_accurate);
if (etmv1_cycle_accurate)
tracemode |= ETMV1_CYCLE_ACCURATE;
else if (strcmp(CMD_ARGV[2], "disable") == 0)
tracemode |= 0;
else
{
command_print(CMD_CTX, "invalid option '%s'", CMD_ARGV[2]);
return ERROR_INVALID_ARGUMENTS;
}
if (strcmp(CMD_ARGV[3], "enable") == 0)
bool etmv1_branch_output;
COMMAND_PARSE_ENABLE(CMD_ARGV[3], etmv1_branch_output);
tracemode |= ETMV1_BRANCH_OUTPUT;
else if (strcmp(CMD_ARGV[3], "disable") == 0)
tracemode |= 0;
else
{
command_print(CMD_CTX, "invalid option '%s'", CMD_ARGV[3]);
return ERROR_INVALID_ARGUMENTS;
}
/* IGNORED:
* - CPRT tracing (coprocessor register transfers)