target: Add 64-bit target address support
Define a target_addr_t type to support 32-bit and 64-bit addresses at the same time. Also define matching TARGET_PRI*ADDR format macros as well as a convenient TARGET_ADDR_FMT. In targets that are 32-bit (avr32, nds32, arm7/9/11, fm4, xmc1000) be least invasive by leaving the formatting unchanged apart from the type; for generic code adopt TARGET_ADDR_FMT as unified address format. Don't silently change gdb formatting here, leave that to later. Add COMMAND_PARSE_ADDRESS() macro to abstract the address type. Implement it using its own parse_target_addr() function, in the hopes of catching pointer type mismatches better. Add '--disable-target64' configure option to revert to previous 32-bit target address behavior. Change-Id: I2e91d205862ceb14f94b3e72a7e99ee0373a85d5 Signed-off-by: Dongxue Zhang <elta.era@gmail.com> Signed-off-by: David Ung <david.ung.42@gmail.com> [AF: Default to enabling (Paul Fertser), rename macros, simplify] Signed-off-by: Andreas Färber <afaerber@suse.de> Signed-off-by: Matthias Welwarsky <matthias.welwarsky@sysgo.com>
This commit is contained in:
committed by
Matthias Welwarsky
parent
0ecee83266
commit
47b8cf8420
@@ -42,7 +42,7 @@
|
||||
|
||||
|
||||
static int arm11_step(struct target *target, int current,
|
||||
uint32_t address, int handle_breakpoints);
|
||||
target_addr_t address, int handle_breakpoints);
|
||||
|
||||
|
||||
/** Check and if necessary take control of the system
|
||||
@@ -449,7 +449,7 @@ static uint32_t arm11_nextpc(struct arm11_common *arm11, int current, uint32_t a
|
||||
}
|
||||
|
||||
static int arm11_resume(struct target *target, int current,
|
||||
uint32_t address, int handle_breakpoints, int debug_execution)
|
||||
target_addr_t address, int handle_breakpoints, int debug_execution)
|
||||
{
|
||||
/* LOG_DEBUG("current %d address %08x handle_breakpoints %d debug_execution %d", */
|
||||
/* current, address, handle_breakpoints, debug_execution); */
|
||||
@@ -467,7 +467,7 @@ static int arm11_resume(struct target *target, int current,
|
||||
|
||||
address = arm11_nextpc(arm11, current, address);
|
||||
|
||||
LOG_DEBUG("RESUME PC %08" PRIx32 "%s", address, !current ? "!" : "");
|
||||
LOG_DEBUG("RESUME PC %08" TARGET_PRIxADDR "%s", address, !current ? "!" : "");
|
||||
|
||||
/* clear breakpoints/watchpoints and VCR*/
|
||||
CHECK_RETVAL(arm11_sc7_clear_vbw(arm11));
|
||||
@@ -481,7 +481,7 @@ static int arm11_resume(struct target *target, int current,
|
||||
|
||||
for (bp = target->breakpoints; bp; bp = bp->next) {
|
||||
if (bp->address == address) {
|
||||
LOG_DEBUG("must step over %08" PRIx32 "", bp->address);
|
||||
LOG_DEBUG("must step over %08" TARGET_PRIxADDR "", bp->address);
|
||||
arm11_step(target, 1, 0, 0);
|
||||
break;
|
||||
}
|
||||
@@ -507,7 +507,7 @@ static int arm11_resume(struct target *target, int current,
|
||||
|
||||
CHECK_RETVAL(arm11_sc7_run(arm11, brp, ARRAY_SIZE(brp)));
|
||||
|
||||
LOG_DEBUG("Add BP %d at %08" PRIx32, brp_num,
|
||||
LOG_DEBUG("Add BP %d at %08" TARGET_PRIxADDR, brp_num,
|
||||
bp->address);
|
||||
|
||||
brp_num++;
|
||||
@@ -557,7 +557,7 @@ static int arm11_resume(struct target *target, int current,
|
||||
}
|
||||
|
||||
static int arm11_step(struct target *target, int current,
|
||||
uint32_t address, int handle_breakpoints)
|
||||
target_addr_t address, int handle_breakpoints)
|
||||
{
|
||||
LOG_DEBUG("target->state: %s",
|
||||
target_state_name(target));
|
||||
@@ -571,7 +571,7 @@ static int arm11_step(struct target *target, int current,
|
||||
|
||||
address = arm11_nextpc(arm11, current, address);
|
||||
|
||||
LOG_DEBUG("STEP PC %08" PRIx32 "%s", address, !current ? "!" : "");
|
||||
LOG_DEBUG("STEP PC %08" TARGET_PRIxADDR "%s", address, !current ? "!" : "");
|
||||
|
||||
|
||||
/** \todo TODO: Thumb not supported here */
|
||||
@@ -583,13 +583,13 @@ static int arm11_step(struct target *target, int current,
|
||||
/* skip over BKPT */
|
||||
if ((next_instruction & 0xFFF00070) == 0xe1200070) {
|
||||
address = arm11_nextpc(arm11, 0, address + 4);
|
||||
LOG_DEBUG("Skipping BKPT %08" PRIx32, address);
|
||||
LOG_DEBUG("Skipping BKPT %08" TARGET_PRIxADDR, address);
|
||||
}
|
||||
/* skip over Wait for interrupt / Standby
|
||||
* mcr 15, 0, r?, cr7, cr0, {4} */
|
||||
else if ((next_instruction & 0xFFFF0FFF) == 0xee070f90) {
|
||||
address = arm11_nextpc(arm11, 0, address + 4);
|
||||
LOG_DEBUG("Skipping WFI %08" PRIx32, address);
|
||||
LOG_DEBUG("Skipping WFI %08" TARGET_PRIxADDR, address);
|
||||
}
|
||||
/* ignore B to self */
|
||||
else if ((next_instruction & 0xFEFFFFFF) == 0xeafffffe)
|
||||
@@ -887,7 +887,7 @@ static int arm11_read_memory_inner(struct target *target,
|
||||
}
|
||||
|
||||
static int arm11_read_memory(struct target *target,
|
||||
uint32_t address,
|
||||
target_addr_t address,
|
||||
uint32_t size,
|
||||
uint32_t count,
|
||||
uint8_t *buffer)
|
||||
@@ -1043,7 +1043,7 @@ static int arm11_write_memory_inner(struct target *target,
|
||||
}
|
||||
|
||||
static int arm11_write_memory(struct target *target,
|
||||
uint32_t address, uint32_t size,
|
||||
target_addr_t address, uint32_t size,
|
||||
uint32_t count, const uint8_t *buffer)
|
||||
{
|
||||
/* pointer increment matters only for multi-unit writes ...
|
||||
|
||||
Reference in New Issue
Block a user