target: Add 64-bit target address support
Define a target_addr_t type to support 32-bit and 64-bit addresses at the same time. Also define matching TARGET_PRI*ADDR format macros as well as a convenient TARGET_ADDR_FMT. In targets that are 32-bit (avr32, nds32, arm7/9/11, fm4, xmc1000) be least invasive by leaving the formatting unchanged apart from the type; for generic code adopt TARGET_ADDR_FMT as unified address format. Don't silently change gdb formatting here, leave that to later. Add COMMAND_PARSE_ADDRESS() macro to abstract the address type. Implement it using its own parse_target_addr() function, in the hopes of catching pointer type mismatches better. Add '--disable-target64' configure option to revert to previous 32-bit target address behavior. Change-Id: I2e91d205862ceb14f94b3e72a7e99ee0373a85d5 Signed-off-by: Dongxue Zhang <elta.era@gmail.com> Signed-off-by: David Ung <david.ung.42@gmail.com> [AF: Default to enabling (Paul Fertser), rename macros, simplify] Signed-off-by: Andreas Färber <afaerber@suse.de> Signed-off-by: Matthias Welwarsky <matthias.welwarsky@sysgo.com>
This commit is contained in:
committed by
Matthias Welwarsky
parent
0ecee83266
commit
47b8cf8420
@@ -59,7 +59,7 @@
|
||||
|
||||
/* forward declarations */
|
||||
static int xscale_resume(struct target *, int current,
|
||||
uint32_t address, int handle_breakpoints, int debug_execution);
|
||||
target_addr_t address, int handle_breakpoints, int debug_execution);
|
||||
static int xscale_debug_entry(struct target *);
|
||||
static int xscale_restore_banked(struct target *);
|
||||
static int xscale_get_reg(struct reg *reg);
|
||||
@@ -1120,7 +1120,7 @@ static void xscale_free_trace_data(struct xscale_common *xscale)
|
||||
}
|
||||
|
||||
static int xscale_resume(struct target *target, int current,
|
||||
uint32_t address, int handle_breakpoints, int debug_execution)
|
||||
target_addr_t address, int handle_breakpoints, int debug_execution)
|
||||
{
|
||||
struct xscale_common *xscale = target_to_xscale(target);
|
||||
struct arm *arm = &xscale->arm;
|
||||
@@ -1165,7 +1165,8 @@ static int xscale_resume(struct target *target, int current,
|
||||
enum trace_mode saved_trace_mode;
|
||||
|
||||
/* there's a breakpoint at the current PC, we have to step over it */
|
||||
LOG_DEBUG("unset breakpoint at 0x%8.8" PRIx32 "", breakpoint->address);
|
||||
LOG_DEBUG("unset breakpoint at " TARGET_ADDR_FMT "",
|
||||
breakpoint->address);
|
||||
xscale_unset_breakpoint(target, breakpoint);
|
||||
|
||||
/* calculate PC of next instruction */
|
||||
@@ -1222,7 +1223,8 @@ static int xscale_resume(struct target *target, int current,
|
||||
LOG_DEBUG("disable single-step");
|
||||
xscale_disable_single_step(target);
|
||||
|
||||
LOG_DEBUG("set breakpoint at 0x%8.8" PRIx32 "", breakpoint->address);
|
||||
LOG_DEBUG("set breakpoint at " TARGET_ADDR_FMT "",
|
||||
breakpoint->address);
|
||||
xscale_set_breakpoint(target, breakpoint);
|
||||
}
|
||||
}
|
||||
@@ -1384,7 +1386,7 @@ static int xscale_step_inner(struct target *target, int current,
|
||||
}
|
||||
|
||||
static int xscale_step(struct target *target, int current,
|
||||
uint32_t address, int handle_breakpoints)
|
||||
target_addr_t address, int handle_breakpoints)
|
||||
{
|
||||
struct arm *arm = target_to_arm(target);
|
||||
struct breakpoint *breakpoint = NULL;
|
||||
@@ -1778,7 +1780,7 @@ dirty:
|
||||
return ERROR_OK;
|
||||
}
|
||||
|
||||
static int xscale_read_memory(struct target *target, uint32_t address,
|
||||
static int xscale_read_memory(struct target *target, target_addr_t address,
|
||||
uint32_t size, uint32_t count, uint8_t *buffer)
|
||||
{
|
||||
struct xscale_common *xscale = target_to_xscale(target);
|
||||
@@ -1786,7 +1788,7 @@ static int xscale_read_memory(struct target *target, uint32_t address,
|
||||
uint32_t i;
|
||||
int retval;
|
||||
|
||||
LOG_DEBUG("address: 0x%8.8" PRIx32 ", size: 0x%8.8" PRIx32 ", count: 0x%8.8" PRIx32,
|
||||
LOG_DEBUG("address: " TARGET_ADDR_FMT ", size: 0x%8.8" PRIx32 ", count: 0x%8.8" PRIx32,
|
||||
address,
|
||||
size,
|
||||
count);
|
||||
@@ -1864,7 +1866,7 @@ static int xscale_read_memory(struct target *target, uint32_t address,
|
||||
return ERROR_OK;
|
||||
}
|
||||
|
||||
static int xscale_read_phys_memory(struct target *target, uint32_t address,
|
||||
static int xscale_read_phys_memory(struct target *target, target_addr_t address,
|
||||
uint32_t size, uint32_t count, uint8_t *buffer)
|
||||
{
|
||||
struct xscale_common *xscale = target_to_xscale(target);
|
||||
@@ -1879,13 +1881,13 @@ static int xscale_read_phys_memory(struct target *target, uint32_t address,
|
||||
return ERROR_FAIL;
|
||||
}
|
||||
|
||||
static int xscale_write_memory(struct target *target, uint32_t address,
|
||||
static int xscale_write_memory(struct target *target, target_addr_t address,
|
||||
uint32_t size, uint32_t count, const uint8_t *buffer)
|
||||
{
|
||||
struct xscale_common *xscale = target_to_xscale(target);
|
||||
int retval;
|
||||
|
||||
LOG_DEBUG("address: 0x%8.8" PRIx32 ", size: 0x%8.8" PRIx32 ", count: 0x%8.8" PRIx32,
|
||||
LOG_DEBUG("address: " TARGET_ADDR_FMT ", size: 0x%8.8" PRIx32 ", count: 0x%8.8" PRIx32,
|
||||
address,
|
||||
size,
|
||||
count);
|
||||
@@ -1963,7 +1965,7 @@ static int xscale_write_memory(struct target *target, uint32_t address,
|
||||
return ERROR_OK;
|
||||
}
|
||||
|
||||
static int xscale_write_phys_memory(struct target *target, uint32_t address,
|
||||
static int xscale_write_phys_memory(struct target *target, target_addr_t address,
|
||||
uint32_t size, uint32_t count, const uint8_t *buffer)
|
||||
{
|
||||
struct xscale_common *xscale = target_to_xscale(target);
|
||||
@@ -3093,7 +3095,7 @@ COMMAND_HANDLER(xscale_handle_cache_info_command)
|
||||
}
|
||||
|
||||
static int xscale_virt2phys(struct target *target,
|
||||
uint32_t virtual, uint32_t *physical)
|
||||
target_addr_t virtual, target_addr_t *physical)
|
||||
{
|
||||
struct xscale_common *xscale = target_to_xscale(target);
|
||||
uint32_t cb;
|
||||
|
||||
Reference in New Issue
Block a user