auracaster/openocd
3
0
Fork 1
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

fileio: improve API types

Browse Source 
Use size_t instead of uint32_t when specifying file sizes.  Update all
consumers up through the layers to use size_t when required.  These
changes should be safe, but the higher-levels will need to be updated
further to receive the intended benefits (i.e. large file support).

Add error checking for fileio_read and file_write.  Previously, all
errors were being silently ignored, so this change might cause some
problems for some people in some cases.  However, it gives us the chance
to handle any errors that do occur at higher-levels, rather than burying
our heads in the sand.
This commit is contained in:
Zachary T Welch
2009-11-13 14:44:53 -08:00
parent 69df712d1d
commit 51862bb98c
12 changed files with 66 additions and 64 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
src/flash/flash.c
View File

@@ -811,7 +811,6 @@ COMMAND_HANDLER(handle_flash_write_bank_command)
{
uint32_t offset;
uint8_t *buffer;
uint32_t buf_cnt;
struct fileio fileio;
if (argc != 3)
@@ -833,6 +832,7 @@ COMMAND_HANDLER(handle_flash_write_bank_command)
}
buffer = malloc(fileio.size);
size_t buf_cnt;
if (fileio_read(&fileio, fileio.size, buffer, &buf_cnt) != ERROR_OK)
{
free(buffer);
@@ -1059,7 +1059,7 @@ static int flash_write_unlock(struct target *target, struct image *image, uint32
/* read sections to the buffer */
while (buffer_size < run_size)
{
uint32_t size_read;
size_t size_read;
size_read = run_size - buffer_size;
if (size_read > image->sections[section].size - section_offset)