NOR: invalidate cached state on target resume

The NOR infrastructure caches some per-sector state, but
it's not used much ... because the cache is not trustworthy.

This patch addresses one part of that problem, by ensuring
that state cached by NOR drivers gets invalidated once we
resume the target -- since targets may then modify sectors.

Now if we see sector protection or erase status marked as
anything other than "unknown", we should be able to rely
on that as being accurate.  (That is ... if we assume the
drivers initialize and update this state correctly.)

Another part of that problem is that the cached state isn't
much used (being unreliable, it would have been unsafe).
Those issues can be addressed in later patches.

Signed-off-by: David Brownell <dbrownell@users.sourceforge.net>
This commit is contained in:
David Brownell
2010-03-03 20:57:49 -08:00
parent 99939c3c75
commit 5fdf9535ce
3 changed files with 44 additions and 0 deletions

View File

@@ -35,6 +35,7 @@
#include <helper/time_support.h>
#include <jtag/jtag.h>
#include <flash/nor/core.h>
#include "target.h"
#include "target_type.h"
@@ -472,6 +473,14 @@ int target_resume(struct target *target, int current, uint32_t address, int hand
if ((retval = target->type->resume(target, current, address, handle_breakpoints, debug_execution)) != ERROR_OK)
return retval;
/* Invalidate any cached protect/erase/... flash status, since
* almost all targets will now be able modify the flash by
* themselves. We want flash drivers and infrastructure to
* be able to rely on (non-invalidated) cached state.
*
* REVISIT do the same for NAND ; maybe other flash flavors too...
*/
nor_resume(target);
return retval;
}