helper/command: change prototype of command_print/command_print_sameline
To prepare for handling TCL return values consistently, all calls to command_print/command_print_sameline should switch to CMD as first parameter. Change prototype of command_print() and command_print_sameline() to pass CMD instead of CMD_CTX. Since the first parameter is currently not used, the change can be done though scripts without manual coding. This patch is created using the command: sed -i PATTERN $(find src/ doc/ -type f) with all the following patters: 's/\(command_print(cmd\)->ctx,/\1,/' 's/\(command_print(CMD\)_CTX,/\1,/' 's/\(command_print(struct command_\)context \*context,/\1invocation *cmd,/' 's/\(command_print_sameline(cmd\)->ctx,/\1,/' 's/\(command_print_sameline(CMD\)_CTX,/\1,/' 's/\(command_print_sameline(struct command_\)context \*context,/\1invocation *cmd,/' This change is inspired by http://openocd.zylin.com/1815 from Paul Fertser but is now done through scripting. Change-Id: I3386d8f96cdc477e7a2308dd18269de3bed04385 Signed-off-by: Antonio Borneo <borneo.antonio@gmail.com> Signed-off-by: Paul Fertser <fercerpav@gmail.com> Reviewed-on: http://openocd.zylin.com/5081 Tested-by: jenkins Reviewed-by: Tomas Vanek <vanekt@fbl.cz>
This commit is contained in:
committed by
Tomas Vanek
parent
6916550938
commit
6cb5ba6f11
@@ -501,7 +501,7 @@ COMMAND_HANDLER(lpc2900_handle_signature_command)
|
||||
if (status != ERROR_OK)
|
||||
return status;
|
||||
|
||||
command_print(CMD_CTX, "signature: 0x%8.8" PRIx32
|
||||
command_print(CMD, "signature: 0x%8.8" PRIx32
|
||||
":0x%8.8" PRIx32
|
||||
":0x%8.8" PRIx32
|
||||
":0x%8.8" PRIx32,
|
||||
@@ -595,11 +595,11 @@ COMMAND_HANDLER(lpc2900_handle_password_command)
|
||||
lpc2900_info->risky = !strcmp(CMD_ARGV[1], ISS_PASSWORD);
|
||||
|
||||
if (!lpc2900_info->risky) {
|
||||
command_print(CMD_CTX, "Wrong password (use '%s')", ISS_PASSWORD);
|
||||
command_print(CMD, "Wrong password (use '%s')", ISS_PASSWORD);
|
||||
return ERROR_COMMAND_ARGUMENT_INVALID;
|
||||
}
|
||||
|
||||
command_print(CMD_CTX,
|
||||
command_print(CMD,
|
||||
"Potentially dangerous operation allowed in next command!");
|
||||
|
||||
return ERROR_OK;
|
||||
@@ -622,7 +622,7 @@ COMMAND_HANDLER(lpc2900_handle_write_custom_command)
|
||||
|
||||
/* Check if command execution is allowed. */
|
||||
if (!lpc2900_info->risky) {
|
||||
command_print(CMD_CTX, "Command execution not allowed!");
|
||||
command_print(CMD, "Command execution not allowed!");
|
||||
return ERROR_COMMAND_ARGUMENT_INVALID;
|
||||
}
|
||||
lpc2900_info->risky = 0;
|
||||
@@ -721,7 +721,7 @@ COMMAND_HANDLER(lpc2900_handle_secure_sector_command)
|
||||
|
||||
/* Check if command execution is allowed. */
|
||||
if (!lpc2900_info->risky) {
|
||||
command_print(CMD_CTX, "Command execution not allowed! "
|
||||
command_print(CMD, "Command execution not allowed! "
|
||||
"(use 'password' command first)");
|
||||
return ERROR_COMMAND_ARGUMENT_INVALID;
|
||||
}
|
||||
@@ -734,7 +734,7 @@ COMMAND_HANDLER(lpc2900_handle_secure_sector_command)
|
||||
if ((first >= bank->num_sectors) ||
|
||||
(last >= bank->num_sectors) ||
|
||||
(first > last)) {
|
||||
command_print(CMD_CTX, "Illegal sector range");
|
||||
command_print(CMD, "Illegal sector range");
|
||||
return ERROR_COMMAND_ARGUMENT_INVALID;
|
||||
}
|
||||
|
||||
@@ -773,7 +773,7 @@ COMMAND_HANDLER(lpc2900_handle_secure_sector_command)
|
||||
}
|
||||
}
|
||||
|
||||
command_print(CMD_CTX,
|
||||
command_print(CMD,
|
||||
"Sectors security will become effective after next power cycle");
|
||||
|
||||
/* Update the sector security status */
|
||||
@@ -803,7 +803,7 @@ COMMAND_HANDLER(lpc2900_handle_secure_jtag_command)
|
||||
|
||||
/* Check if command execution is allowed. */
|
||||
if (!lpc2900_info->risky) {
|
||||
command_print(CMD_CTX, "Command execution not allowed! "
|
||||
command_print(CMD, "Command execution not allowed! "
|
||||
"(use 'password' command first)");
|
||||
return ERROR_COMMAND_ARGUMENT_INVALID;
|
||||
}
|
||||
|
||||
Reference in New Issue
Block a user