auracaster/openocd
3
0
Fork 1
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

target/image: Use proper data types

Browse Source 
While at it, fix some coding style issues.

Change-Id: Id521394d89e0bf787a6f812701c2cc0fe7e4e63f
Signed-off-by: Marc Schink <dev@zapb.de>
Reviewed-on: http://openocd.zylin.com/5919
Tested-by: jenkins
Reviewed-by: Antonio Borneo <borneo.antonio@gmail.com>
This commit is contained in:
Marc Schink
2020-11-03 16:11:48 +01:00
committed by Antonio Borneo
parent 6dbfdcd00f
commit 73746d78b7
10 changed files with 46 additions and 56 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
src/flash/nor/core.c
View File

@@ -702,7 +702,7 @@ int flash_write_unlock(struct target *target, struct image *image,
{
int retval = ERROR_OK;
int section;
unsigned int section;
uint32_t section_offset;
struct flash_bank *c;
int *padding;
@@ -727,8 +727,8 @@ int flash_write_unlock(struct target *target, struct image *image,
* whereas an image can have sections out of order. */
struct imagesection **sections = malloc(sizeof(struct imagesection *) *
image->num_sections);
int i;
for (i = 0; i < image->num_sections; i++)
for (unsigned int i = 0; i < image->num_sections; i++)
sections[i] = &image->sections[i];
qsort(sections, image->num_sections, sizeof(struct imagesection *),
@@ -738,7 +738,7 @@ int flash_write_unlock(struct target *target, struct image *image,
while (section < image->num_sections) {
uint32_t buffer_idx;
uint8_t *buffer;
int section_last;
unsigned int section_last;
target_addr_t run_address = sections[section]->base_address + section_offset;
uint32_t run_size = sections[section]->size - section_offset;
int pad_bytes = 0;

4
src/flash/nor/lpc2900.c
View File

@@ -635,9 +635,9 @@ COMMAND_HANDLER(lpc2900_handle_write_custom_command)
/* The image will always start at offset 0 */
struct image image;
image.base_address_set = 1;
image.base_address_set = true;
image.base_address = 0;
image.start_address_set = 0;
image.start_address_set = false;
const char *filename = CMD_ARGV[1];
const char *type = (CMD_ARGC >= 3) ? CMD_ARGV[2] : NULL;

6
src/flash/nor/tcl.c
View File

@@ -441,14 +441,14 @@ COMMAND_HANDLER(handle_flash_write_image_command)
duration_start(&bench);
if (CMD_ARGC >= 2) {
image.base_address_set = 1;
image.base_address_set = true;
COMMAND_PARSE_NUMBER(llong, CMD_ARGV[1], image.base_address);
} else {
image.base_address_set = 0;
image.base_address_set = false;
image.base_address = 0x0;
}
image.start_address_set = 0;
image.start_address_set = false;
retval = image_open(&image, CMD_ARGV[0], (CMD_ARGC == 3) ? CMD_ARGV[2] : NULL);
if (retval != ERROR_OK)