flash: stop caching protection state

There are a million reasons why cached protection state might
be stale: power cycling of target, reset, code executing on
the target, etc.

The "flash protect_check" command is now gone. This is *always*
executed when running a "flash info".

As a bonus for more a more robust approach, lots of code could
be deleted.

Signed-off-by: Øyvind Harboe <oyvind.harboe@zylin.com>
This commit is contained in:
Øyvind Harboe
2010-05-05 15:08:34 +02:00
parent f7e0f3c285
commit 737c9b6258
6 changed files with 33 additions and 150 deletions

View File

@@ -474,19 +474,6 @@ int target_resume(struct target *target, int current, uint32_t address, int hand
if ((retval = target->type->resume(target, current, address, handle_breakpoints, debug_execution)) != ERROR_OK)
return retval;
/* Invalidate any cached protect/erase/... flash status, since
* almost all targets will now be able modify the flash by
* themselves. We want flash drivers and infrastructure to
* be able to rely on (non-invalidated) cached state.
*
* For now we require that algorithms provided by OpenOCD are
* used only by code which properly maintains that cached state.
* state
*
* REVISIT do the same for NAND ; maybe other flash flavors too...
*/
if (!target->running_alg)
nor_resume(target);
return retval;
}