auracaster/openocd
3
0
Fork 1
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

drivers: xds110: Clean up command syntax and documentation

Browse Source 
Arrange all commands under a top level xds110 command. Fix
documentation to properly reflect the current functionality.

Also updated the links in the document to the new permanent
links for the XDS110 only support.

Patch updated for comments from code review. Return
ERROR_COMMAND_SYNTAX_ERROR for wrong number of args in
commands. Added deprecated commands to src/jtag/startup.tcl.

Change-Id: Ica45f65e1fdf7fa72866f4e28c4f6bce428d8ac9
Signed-off-by: Edward Fewell <efewell@ti.com>
Reviewed-on: http://openocd.zylin.com/5495
Tested-by: jenkins
Reviewed-by: Antonio Borneo <borneo.antonio@gmail.com>
This commit is contained in:
Edward Fewell
2020-03-04 17:24:33 -06:00
committed by Antonio Borneo
parent 76ba9bd0b3
commit 87a4158acf
3 changed files with 49 additions and 35 deletions
Download Patch File Download Diff File Expand all files Collapse all files

46
src/jtag/drivers/xds110.c
View File

@@ -2028,11 +2028,8 @@ COMMAND_HANDLER(xds110_handle_serial_command)
xds110.serial[i] = (char)serial[i];
xds110.serial[len] = 0;
} else {
LOG_ERROR("XDS110: expected exactly one argument to xds110_serial "
"<serial-number>");
return ERROR_FAIL;
}
} else
return ERROR_COMMAND_SYNTAX_ERROR;
return ERROR_OK;
}
@@ -2053,11 +2050,8 @@ COMMAND_HANDLER(xds110_handle_supply_voltage_command)
return ERROR_FAIL;
}
xds110.voltage = voltage;
} else {
LOG_ERROR("XDS110: expected one argument to xds110_supply_voltage "
"<millivolts>");
return ERROR_FAIL;
}
} else
return ERROR_COMMAND_SYNTAX_ERROR;
return ERROR_OK;
}
@@ -2067,8 +2061,22 @@ static const struct command_registration xds110_subcommand_handlers[] = {
.name = "info",
.handler = &xds110_handle_info_command,
.mode = COMMAND_EXEC,
.usage = "",
.help = "show XDS110 info",
.usage = "",
},
{
.name = "serial",
.handler = &xds110_handle_serial_command,
.mode = COMMAND_CONFIG,
.help = "set the XDS110 probe serial number",
.usage = "serial_string",
},
{
.name = "supply",
.handler = &xds110_handle_supply_voltage_command,
.mode = COMMAND_CONFIG,
.help = "set the XDS110 probe supply voltage",
.usage = "voltage_in_millivolts",
},
COMMAND_REGISTRATION_DONE
};
@@ -2078,23 +2086,9 @@ static const struct command_registration xds110_command_handlers[] = {
.name = "xds110",
.mode = COMMAND_ANY,
.help = "perform XDS110 management",
.usage = "<cmd>",
.usage = "",
.chain = xds110_subcommand_handlers,
},
{
.name = "xds110_serial",
.handler = &xds110_handle_serial_command,
.mode = COMMAND_CONFIG,
.help = "set the XDS110 probe serial number",
.usage = "serial_string",
},
{
.name = "xds110_supply_voltage",
.handler = &xds110_handle_supply_voltage_command,
.mode = COMMAND_CONFIG,
.help = "set the XDS110 probe supply voltage",
.usage = "supply_voltage (millivolts)",
},
COMMAND_REGISTRATION_DONE
};

10
src/jtag/startup.tcl
View File

@@ -216,4 +216,14 @@ proc ftdi_location args {
eval adapter usb location $args
}
proc xds110_serial args {
echo "DEPRECATED! use 'xds110 serial' not 'xds110_serial'"
eval xds110 serial $args
}
proc xds110_supply_voltage args {
echo "DEPRECATED! use 'xds110 supply' not 'xds110_supply_voltage'"
eval xds110 supply $args
}
# END MIGRATION AIDS