auracaster/openocd
3
0
Fork 1
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Constify received GDB packet

Browse Source 
v2:
- Split work into separate patches

The received packet will not be altered in any of the processing functions.
Some it can be made "const".

Change-Id: I7bb410224cf6daa74a6c494624176ccb9ae638ac
Signed-off-by: Christian Eggers <ceggers@gmx.de>
Reviewed-on: http://openocd.zylin.com/1919
Tested-by: jenkins
Reviewed-by: Spencer Oliver <spen@spen-soft.co.uk>
This commit is contained in:
Christian Eggers
2014-02-14 21:48:52 +01:00
committed by Spencer Oliver
parent 537b06a810
commit 9b2577742c
8 changed files with 46 additions and 46 deletions
Download Patch File Download Diff File Expand all files Collapse all files

14
src/rtos/linux.c
View File

@@ -351,7 +351,7 @@ const struct rtos_type Linux_os = {
.ps_command = linux_ps_command,
};
static int linux_thread_packet(struct connection *connection, char *packet,
static int linux_thread_packet(struct connection *connection, char const *packet,
int packet_size);
static void linux_identify_current_threads(struct target *target);
@@ -1117,7 +1117,7 @@ static int linux_task_update(struct target *target, int context)
}
int linux_gdb_thread_packet(struct target *target,
struct connection *connection, char *packet,
struct connection *connection, char const *packet,
int packet_size)
{
int retval;
@@ -1153,7 +1153,7 @@ int linux_gdb_thread_packet(struct target *target,
}
int linux_gdb_thread_update(struct target *target,
struct connection *connection, char *packet,
struct connection *connection, char const *packet,
int packet_size)
{
int found = 0;
@@ -1200,7 +1200,7 @@ int linux_gdb_thread_update(struct target *target,
}
int linux_thread_extra_info(struct target *target,
struct connection *connection, char *packet,
struct connection *connection, char const *packet,
int packet_size)
{
int64_t threadid = 0;
@@ -1247,7 +1247,7 @@ int linux_thread_extra_info(struct target *target,
}
int linux_gdb_T_packet(struct connection *connection,
struct target *target, char *packet, int packet_size)
struct target *target, char const *packet, int packet_size)
{
int64_t threadid;
struct linux_os *linux_os = (struct linux_os *)
@@ -1308,7 +1308,7 @@ int linux_gdb_T_packet(struct connection *connection,
}
int linux_gdb_h_packet(struct connection *connection,
struct target *target, char *packet, int packet_size)
struct target *target, char const *packet, int packet_size)
{
struct linux_os *linux_os = (struct linux_os *)
target->rtos->rtos_specific_params;
@@ -1376,7 +1376,7 @@ int linux_gdb_h_packet(struct connection *connection,
return ERROR_OK;
}
static int linux_thread_packet(struct connection *connection, char *packet,
static int linux_thread_packet(struct connection *connection, char const *packet,
int packet_size)
{
int retval = ERROR_OK;

8
src/rtos/rtos.c
View File

@@ -46,7 +46,7 @@ static struct rtos_type *rtos_types[] = {
NULL
};
int rtos_thread_packet(struct connection *connection, char *packet, int packet_size);
int rtos_thread_packet(struct connection *connection, const char *packet, int packet_size);
int rtos_smp_init(struct target *target)
{
@@ -138,7 +138,7 @@ int rtos_create(Jim_GetOptInfo *goi, struct target *target)
return JIM_ERR;
}
int gdb_thread_packet(struct connection *connection, char *packet, int packet_size)
int gdb_thread_packet(struct connection *connection, char const *packet, int packet_size)
{
struct target *target = get_target_from_connection(connection);
if (target->rtos == NULL)
@@ -186,7 +186,7 @@ static char *next_symbol(struct rtos *os, char *cur_symbol, uint64_t cur_addr)
*
* rtos_qsymbol() returns 1 if an RTOS has been detected, or 0 otherwise.
*/
int rtos_qsymbol(struct connection *connection, char *packet, int packet_size)
int rtos_qsymbol(struct connection *connection, char const *packet, int packet_size)
{
int rtos_detected = 0;
uint64_t addr = 0;
@@ -254,7 +254,7 @@ done:
return rtos_detected;
}
int rtos_thread_packet(struct connection *connection, char *packet, int packet_size)
int rtos_thread_packet(struct connection *connection, char const *packet, int packet_size)
{
struct target *target = get_target_from_connection(connection);

6
src/rtos/rtos.h
View File

@@ -56,7 +56,7 @@ struct rtos {
threadid_t current_thread;
struct thread_detail *thread_details;
int thread_count;
int (*gdb_thread_packet)(struct connection *connection, char *packet, int packet_size);
int (*gdb_thread_packet)(struct connection *connection, char const *packet, int packet_size);
void *rtos_specific_params;
};
@@ -95,12 +95,12 @@ int rtos_generic_stack_read(struct target *target,
int64_t stack_ptr,
char **hex_reg_list);
int rtos_try_next(struct target *target);
int gdb_thread_packet(struct connection *connection, char *packet, int packet_size);
int gdb_thread_packet(struct connection *connection, char const *packet, int packet_size);
int rtos_get_gdb_reg_list(struct connection *connection);
int rtos_update_threads(struct target *target);
void rtos_free_threadlist(struct rtos *rtos);
int rtos_smp_init(struct target *target);
/* function for handling symbol access */
int rtos_qsymbol(struct connection *connection, char *packet, int packet_size);
int rtos_qsymbol(struct connection *connection, char const *packet, int packet_size);
#endif /* RTOS_H */