From bd17a59fd14e72a36930af4ab87d3f7b74887206 Mon Sep 17 00:00:00 2001 From: Mark O'Donovan Date: Tue, 24 Feb 2026 20:41:43 +0000 Subject: [PATCH] pld/gowin: move pointer deref after NULL check Move pointer deref after NULL check. Found by cppcheck. Change-Id: Ic1b197fa43fa800cfec631614574dda46b137597 Signed-off-by: Mark O'Donovan Reviewed-on: https://review.openocd.org/c/openocd/+/9500 Reviewed-by: Antonio Borneo Tested-by: jenkins Reviewed-by: Daniel Anselmi --- src/pld/gowin.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/pld/gowin.c b/src/pld/gowin.c index bbc2fe15f..939e61060 100644 --- a/src/pld/gowin.c +++ b/src/pld/gowin.c @@ -172,11 +172,11 @@ static int gowin_read_fs_file(struct gowin_bit_file *bit_file, const char *filen static int gowin_read_file(struct gowin_bit_file *bit_file, const char *filename, bool *is_fs) { - memset(bit_file, 0, sizeof(struct gowin_bit_file)); - if (!filename || !bit_file) return ERROR_COMMAND_SYNTAX_ERROR; + memset(bit_file, 0, sizeof(struct gowin_bit_file)); + const char *file_suffix_pos = strrchr(filename, '.'); if (!file_suffix_pos) { LOG_ERROR("Unable to detect filename suffix");