Consolidate target selection code into single get_target() that handles both names and numbers. Provided by David Brownell <david-b@pacbell.net>
git-svn-id: svn://svn.berlios.de/openocd/trunk@1804 b42882b7-edfa-0310-969c-e2dbd0fdcd60
This commit is contained in:
+2
-2
@@ -164,10 +164,10 @@ static int ecosflash_flash_bank_command(struct command_context_s *cmd_ctx, char
|
||||
bank->sectors[i].is_protected = 0;
|
||||
}
|
||||
|
||||
info->target = get_target_by_num(strtoul(args[5], NULL, 0));
|
||||
info->target = get_target(args[5]);
|
||||
if (info->target == NULL)
|
||||
{
|
||||
LOG_ERROR("no target '%i' configured", (int)strtoul(args[5], NULL, 0));
|
||||
LOG_ERROR("target '%s' not defined", args[5]);
|
||||
return ERROR_FAIL;
|
||||
}
|
||||
return ERROR_OK;
|
||||
|
||||
+2
-2
@@ -261,9 +261,9 @@ static int handle_flash_bank_command(struct command_context_s *cmd_ctx, char *cm
|
||||
return ERROR_COMMAND_SYNTAX_ERROR;
|
||||
}
|
||||
|
||||
if ((target = get_target_by_num(strtoul(args[5], NULL, 0))) == NULL)
|
||||
if ((target = get_target(args[5])) == NULL)
|
||||
{
|
||||
LOG_ERROR("target %lu not defined", strtoul(args[5], NULL, 0));
|
||||
LOG_ERROR("target '%s' not defined", args[5]);
|
||||
return ERROR_FAIL;
|
||||
}
|
||||
|
||||
|
||||
@@ -71,10 +71,10 @@ static int lpc3180_nand_device_command(struct command_context_s *cmd_ctx, char *
|
||||
lpc3180_info = malloc(sizeof(lpc3180_nand_controller_t));
|
||||
device->controller_priv = lpc3180_info;
|
||||
|
||||
lpc3180_info->target = get_target_by_num(strtoul(args[1], NULL, 0));
|
||||
lpc3180_info->target = get_target(args[1]);
|
||||
if (!lpc3180_info->target)
|
||||
{
|
||||
LOG_ERROR("no target '%s' configured", args[1]);
|
||||
LOG_ERROR("target '%s' not defined", args[1]);
|
||||
return ERROR_NAND_DEVICE_INVALID;
|
||||
}
|
||||
|
||||
|
||||
+2
-2
@@ -795,9 +795,9 @@ static int mflash_bank_command(struct command_context_s *cmd_ctx, char *cmd, cha
|
||||
return ERROR_COMMAND_SYNTAX_ERROR;
|
||||
}
|
||||
|
||||
if ((target = get_target_by_num(strtoul(args[7], NULL, 0))) == NULL)
|
||||
if ((target = get_target(args[7])) == NULL)
|
||||
{
|
||||
LOG_ERROR("target %lu not defined", strtoul(args[7], NULL, 0));
|
||||
LOG_ERROR("target '%s' not defined", args[7]);
|
||||
return ERROR_FAIL;
|
||||
}
|
||||
|
||||
|
||||
@@ -210,9 +210,9 @@ int orion_nand_device_command(struct command_context_s *cmd_ctx, char *cmd,
|
||||
}
|
||||
|
||||
device->controller_priv = hw;
|
||||
hw->target = get_target_by_num(strtoul(args[1], NULL, 0));
|
||||
hw->target = get_target(args[1]);
|
||||
if (!hw->target) {
|
||||
LOG_ERROR("no target '%s' configured", args[1]);
|
||||
LOG_ERROR("target '%s' not defined", args[1]);
|
||||
free(hw);
|
||||
return ERROR_NAND_DEVICE_INVALID;
|
||||
}
|
||||
|
||||
@@ -46,12 +46,12 @@ s3c24xx_nand_device_command(struct command_context_s *cmd_ctx, char *cmd,
|
||||
|
||||
device->controller_priv = s3c24xx_info;
|
||||
|
||||
s3c24xx_info->target = get_target_by_num(strtoul(args[1], NULL, 0));
|
||||
s3c24xx_info->target = get_target(args[1]);
|
||||
if (s3c24xx_info->target == NULL) {
|
||||
LOG_ERROR("no target '%s' configured", args[1]);
|
||||
LOG_ERROR("target '%s' not defined", args[1]);
|
||||
return NULL;
|
||||
}
|
||||
|
||||
|
||||
return s3c24xx_info;
|
||||
}
|
||||
|
||||
|
||||
Reference in New Issue
Block a user