auracaster/openocd
3
0
Fork 1
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

cortex_m: Do additional initialization during reset

Browse Source 
SAM4L requires additional steps to be taken right after SYSRESETREQ is
issued in order to function robustly:

       - CMSIS-DAP DAP driver needs to explicitly check for sticky bit
         errors since it is possible for adapter to perform successful
         write opration, report no errors and then, under the hood, do
         some other things that will result in sticky bit being set.

       - Debugger needs to wait for security system to finish
         intialization and assert CDBGPWRUPACK before proceeding

This change is related to commit http://openocd.zylin.com/#/c/1995/

Change-Id: I741c95a809bfd60d930cec9482239e4796a62326
Signed-off-by: Andrey Smirnov <andrew.smirnov@gmail.com>
Reviewed-on: http://openocd.zylin.com/2088
Tested-by: jenkins
Reviewed-by: Andreas Fritiofson <andreas.fritiofson@gmail.com>
Reviewed-by: Andrey Yurovsky <yurovsky@gmail.com>
This commit is contained in:
Andrey Smirnov
2014-04-03 14:59:44 -07:00
committed by Andreas Fritiofson
parent d6fd5d0f9b
commit ccf4d6d648
3 changed files with 43 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

32
src/target/adi_v5_cmsis_dap.c
View File

@@ -167,10 +167,38 @@ static int (cmsis_dap_queue_ap_write)(struct adiv5_dap *dap, unsigned reg, uint3
/** Executes all queued DAP operations. */
static int cmsis_dap_run(struct adiv5_dap *dap)
{
LOG_DEBUG("CMSIS-ADI: cmsis_dap_run");
LOG_DEBUG(" ");
/* FIXME: for now the CMSIS-DAP interface hard-wires a zero-size queue. */
int ret;
uint32_t ctrlstat;
return ERROR_OK;
/*
Some debug dongles do more than asked for(e.g. EDBG from
Atmel) behind the scene and issuing an AP write
may result in more than just APACC SWD transaction, which in
turn can possibly set sticky error bit in CTRL/STAT register
of the DP(an example would be writing SYSRESETREQ to AIRCR).
Such adapters may interpret CMSIS-DAP secification
differently and not guarantee to be report those failures
via status byte of the return USB packet from CMSIS-DAP, so
we need to check CTRL/STAT and if that happens to clear it.
*/
ret = cmsis_dap_queue_dp_read(dap, DP_CTRL_STAT, &ctrlstat);
if (ret != ERROR_OK) {
LOG_ERROR("Failed to read CTRL/STAT register");
return ret;
}
if (ctrlstat & SSTICKYERR) {
LOG_WARNING("SSTICKYERR was set, clearing it");
ret = cmsis_dap_clear_sticky_errors(dap);
if (ret != ERROR_OK) {
LOG_ERROR("Failed to clear sticky errors");
return ret;
}
}
return ret;
}
const struct dap_ops cmsis_dap_ops = {