auracaster/openocd
3
0
Fork 1
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

target: provide container_of()

Browse Source 
Provide a cleaner way to handle single inheritance of targets
in C, using the same model Linux does:  structs containing other
structs, un-nested via calls to a "container_of()" macro that
are packaged in typesafe inline functions.

Targets already use this containment idiom, but make it much
more complicated because they un-nest using embedded "void *"
pointers ... in chains of up to five per target, which is all
pure needless complication.  (Example: arm92x core, arm9tdmi,
arm7_9, armv4_5 ... on top of the base "target" class.)

Applying this scheme consistently simplifies things, and gets
rid of many error-prone untyped pointers.  It won't change any
part of the type model though -- it just simplifies things.
(And facilitates more cleanup later on.)

Rule of thumb:  where there's an X->arch_info void* pointer,
access to that pointer can and should be removed.  It may be
convenient to set up pointers to some of the embedded structs;
and shrink their current "*_common" names (annoyingly long).

Signed-off-by: David Brownell <dbrownell@users.sourceforge.net>
This commit is contained in:
David Brownell
2009-11-05 21:59:39 -08:00
parent b7e4c26b9b
commit db116b1ea3
12 changed files with 91 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
src/target/arm926ejs.h
View File

@@ -38,6 +38,14 @@ typedef struct arm926ejs_common_s
uint32_t d_far;
} arm926ejs_common_t;
static inline struct arm926ejs_common_s *
target_to_arm926(struct target_s *target)
{
return container_of(target->arch_info, struct arm926ejs_common_s,
arm9tdmi_common.arm7_9_common.armv4_5_common);
}
extern int arm926ejs_init_arch_info(target_t *target, arm926ejs_common_t *arm926ejs, jtag_tap_t *tap);
extern int arm926ejs_register_commands(struct command_context_s *cmd_ctx);
extern int arm926ejs_arch_state(struct target_s *target);