auracaster/openocd
3
0
Fork 1
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

target/breakpoints: drop duplicate breakpoint/watchpoint "clear_target" functions

Browse Source 
We need to cleanup watchpoints on all targets in SMP group when GDB
connects. Otherwise, the targets will not be consistent.
Once thats fixed, both *_clear_target functions clearly duplicate
the corresponding *_remove_all functions.

Change-Id: I8e85dbc66fd3e596990d631ed2aed22959a8ca60
Signed-off-by: Samuel Obuch <samuel.obuch@espressif.com>
Reviewed-on: https://review.openocd.org/c/openocd/+/9086
Reviewed-by: Evgeniy Naydanov <evgeniy.naydanov@syntacore.com>
Tested-by: jenkins
Reviewed-by: Tomas Vanek <vanekt@fbl.cz>
This commit is contained in:
Samuel Obuch
2025-08-18 22:05:55 +02:00
committed by Tomas Vanek
parent 896738264e
commit e5888bda38
3 changed files with 6 additions and 44 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
src/target/breakpoints.h
View File

@@ -50,7 +50,6 @@ struct watchpoint {
int unique_id;
};
int breakpoint_clear_target(struct target *target);
int breakpoint_add(struct target *target,
target_addr_t address, unsigned int length, enum breakpoint_type type);
int context_breakpoint_add(struct target *target,
@@ -69,7 +68,6 @@ static inline void breakpoint_hw_set(struct breakpoint *breakpoint, unsigned int
breakpoint->number = hw_number;
}
int watchpoint_clear_target(struct target *target);
int watchpoint_add(struct target *target,
target_addr_t address, unsigned int length,
enum watchpoint_rw rw, uint64_t value, uint64_t mask);