target: convert 'unsigned' to 'unsigned int'
Conversion done with checkpatch --fix-inplace -types UNSPECIFIED_INT Ignore the cast as they could be better addressed. Fix only minor additional checkpatch issue (spacing and line length). Use Checkpatch-ignore below for the function pointers in the file 'armv7a_cache_l2x.h' that do not assign the identifier names to the function arguments. Most of these struct are unused and should be fixed or dropped. Checkpatch-ignore: FUNCTION_ARGUMENTS Change-Id: I8f27e68eb3502e431c1ba801b362358105f9f2dc Signed-off-by: Antonio Borneo <borneo.antonio@gmail.com> Reviewed-on: https://review.openocd.org/c/openocd/+/8480 Tested-by: jenkins Reviewed-by: zapb <dev@zapb.de>
This commit is contained in:
@@ -417,7 +417,7 @@ static int dpmv8_instr_read_data_r0_64(struct arm_dpm *dpm,
|
||||
}
|
||||
|
||||
#if 0
|
||||
static int dpmv8_bpwp_enable(struct arm_dpm *dpm, unsigned index_t,
|
||||
static int dpmv8_bpwp_enable(struct arm_dpm *dpm, unsigned int index_t,
|
||||
target_addr_t addr, uint32_t control)
|
||||
{
|
||||
struct armv8_common *armv8 = dpm->arm->arch_info;
|
||||
@@ -450,7 +450,7 @@ static int dpmv8_bpwp_enable(struct arm_dpm *dpm, unsigned index_t,
|
||||
}
|
||||
#endif
|
||||
|
||||
static int dpmv8_bpwp_disable(struct arm_dpm *dpm, unsigned index_t)
|
||||
static int dpmv8_bpwp_disable(struct arm_dpm *dpm, unsigned int index_t)
|
||||
{
|
||||
struct armv8_common *armv8 = dpm->arm->arch_info;
|
||||
uint32_t cr;
|
||||
@@ -641,7 +641,7 @@ int armv8_dpm_modeswitch(struct arm_dpm *dpm, enum arm_mode mode)
|
||||
/*
|
||||
* Common register read, relies on armv8_select_reg_access() having been called.
|
||||
*/
|
||||
static int dpmv8_read_reg(struct arm_dpm *dpm, struct reg *r, unsigned regnum)
|
||||
static int dpmv8_read_reg(struct arm_dpm *dpm, struct reg *r, unsigned int regnum)
|
||||
{
|
||||
struct armv8_common *armv8 = dpm->arm->arch_info;
|
||||
int retval = ERROR_FAIL;
|
||||
@@ -684,7 +684,7 @@ static int dpmv8_read_reg(struct arm_dpm *dpm, struct reg *r, unsigned regnum)
|
||||
/*
|
||||
* Common register write, relies on armv8_select_reg_access() having been called.
|
||||
*/
|
||||
static int dpmv8_write_reg(struct arm_dpm *dpm, struct reg *r, unsigned regnum)
|
||||
static int dpmv8_write_reg(struct arm_dpm *dpm, struct reg *r, unsigned int regnum)
|
||||
{
|
||||
struct armv8_common *armv8 = dpm->arm->arch_info;
|
||||
int retval = ERROR_FAIL;
|
||||
@@ -887,7 +887,7 @@ int armv8_dpm_write_dirty_registers(struct arm_dpm *dpm, bool bpwp)
|
||||
* cope with the hand-crafted breakpoint code.
|
||||
*/
|
||||
if (arm->target->type->add_breakpoint == dpmv8_add_breakpoint) {
|
||||
for (unsigned i = 0; i < dpm->nbp; i++) {
|
||||
for (unsigned int i = 0; i < dpm->nbp; i++) {
|
||||
struct dpm_bp *dbp = dpm->dbp + i;
|
||||
struct breakpoint *bp = dbp->bp;
|
||||
|
||||
@@ -899,7 +899,7 @@ int armv8_dpm_write_dirty_registers(struct arm_dpm *dpm, bool bpwp)
|
||||
}
|
||||
|
||||
/* enable/disable watchpoints */
|
||||
for (unsigned i = 0; i < dpm->nwp; i++) {
|
||||
for (unsigned int i = 0; i < dpm->nwp; i++) {
|
||||
struct dpm_wp *dwp = dpm->dwp + i;
|
||||
struct watchpoint *wp = dwp->wp;
|
||||
|
||||
@@ -919,7 +919,7 @@ int armv8_dpm_write_dirty_registers(struct arm_dpm *dpm, bool bpwp)
|
||||
goto done;
|
||||
|
||||
/* check everything except our scratch register R0 */
|
||||
for (unsigned i = 1; i < cache->num_regs; i++) {
|
||||
for (unsigned int i = 1; i < cache->num_regs; i++) {
|
||||
struct arm_reg *r;
|
||||
|
||||
/* skip non-existent */
|
||||
@@ -1047,7 +1047,7 @@ static int armv8_dpm_full_context(struct target *target)
|
||||
* Pick some mode with unread registers and read them all.
|
||||
* Repeat until done.
|
||||
*/
|
||||
for (unsigned i = 0; i < cache->num_regs; i++) {
|
||||
for (unsigned int i = 0; i < cache->num_regs; i++) {
|
||||
struct arm_reg *r;
|
||||
|
||||
if (!cache->reg_list[i].exist || cache->reg_list[i].valid)
|
||||
@@ -1175,7 +1175,7 @@ static int dpmv8_add_breakpoint(struct target *target, struct breakpoint *bp)
|
||||
if (bp->type == BKPT_SOFT)
|
||||
LOG_DEBUG("using HW bkpt, not SW...");
|
||||
|
||||
for (unsigned i = 0; i < dpm->nbp; i++) {
|
||||
for (unsigned int i = 0; i < dpm->nbp; i++) {
|
||||
if (!dpm->dbp[i].bp) {
|
||||
retval = dpmv8_bpwp_setup(dpm, &dpm->dbp[i].bpwp,
|
||||
bp->address, bp->length);
|
||||
@@ -1194,7 +1194,7 @@ static int dpmv8_remove_breakpoint(struct target *target, struct breakpoint *bp)
|
||||
struct arm_dpm *dpm = arm->dpm;
|
||||
int retval = ERROR_COMMAND_SYNTAX_ERROR;
|
||||
|
||||
for (unsigned i = 0; i < dpm->nbp; i++) {
|
||||
for (unsigned int i = 0; i < dpm->nbp; i++) {
|
||||
if (dpm->dbp[i].bp == bp) {
|
||||
dpm->dbp[i].bp = NULL;
|
||||
dpm->dbp[i].bpwp.dirty = true;
|
||||
@@ -1208,7 +1208,7 @@ static int dpmv8_remove_breakpoint(struct target *target, struct breakpoint *bp)
|
||||
return retval;
|
||||
}
|
||||
|
||||
static int dpmv8_watchpoint_setup(struct arm_dpm *dpm, unsigned index_t,
|
||||
static int dpmv8_watchpoint_setup(struct arm_dpm *dpm, unsigned int index_t,
|
||||
struct watchpoint *wp)
|
||||
{
|
||||
int retval;
|
||||
@@ -1251,7 +1251,7 @@ static int dpmv8_add_watchpoint(struct target *target, struct watchpoint *wp)
|
||||
int retval = ERROR_TARGET_RESOURCE_NOT_AVAILABLE;
|
||||
|
||||
if (dpm->bpwp_enable) {
|
||||
for (unsigned i = 0; i < dpm->nwp; i++) {
|
||||
for (unsigned int i = 0; i < dpm->nwp; i++) {
|
||||
if (!dpm->dwp[i].wp) {
|
||||
retval = dpmv8_watchpoint_setup(dpm, i, wp);
|
||||
break;
|
||||
@@ -1268,7 +1268,7 @@ static int dpmv8_remove_watchpoint(struct target *target, struct watchpoint *wp)
|
||||
struct arm_dpm *dpm = arm->dpm;
|
||||
int retval = ERROR_COMMAND_SYNTAX_ERROR;
|
||||
|
||||
for (unsigned i = 0; i < dpm->nwp; i++) {
|
||||
for (unsigned int i = 0; i < dpm->nwp; i++) {
|
||||
if (dpm->dwp[i].wp == wp) {
|
||||
dpm->dwp[i].wp = NULL;
|
||||
dpm->dwp[i].bpwp.dirty = true;
|
||||
@@ -1484,7 +1484,7 @@ int armv8_dpm_initialize(struct arm_dpm *dpm)
|
||||
{
|
||||
/* Disable all breakpoints and watchpoints at startup. */
|
||||
if (dpm->bpwp_disable) {
|
||||
unsigned i;
|
||||
unsigned int i;
|
||||
|
||||
for (i = 0; i < dpm->nbp; i++) {
|
||||
dpm->dbp[i].bpwp.number = i;
|
||||
|
||||
Reference in New Issue
Block a user