From ea07cc74ce7c712fe64ea9f7251af3f02114a149 Mon Sep 17 00:00:00 2001 From: Mark O'Donovan Date: Sun, 29 Mar 2026 14:43:11 +0100 Subject: [PATCH] target/dsp5680xx: add missing retval assignment retval was being checked without being assigned. Change-Id: I3a87abb00159414c869e7ad558566f5c062252b3 Signed-off-by: Mark O'Donovan Reviewed-on: https://review.openocd.org/c/openocd/+/9549 Tested-by: jenkins Reviewed-by: Antonio Borneo --- src/target/dsp5680xx.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/target/dsp5680xx.c b/src/target/dsp5680xx.c index 0f0206ffc..09e9a1c96 100644 --- a/src/target/dsp5680xx.c +++ b/src/target/dsp5680xx.c @@ -2068,7 +2068,7 @@ int dsp5680xx_f_wr(struct target *t, const uint8_t *b, uint32_t a, uint32_t coun retval = core_move_long_to_r3(target, address); /* Destination address to r3 */ if (retval != ERROR_OK) return retval; - core_load_tx_rx_high_addr_to_r0(target); /* TX/RX reg address to r0 */ + retval = core_load_tx_rx_high_addr_to_r0(target); /* TX/RX reg address to r0 */ if (retval != ERROR_OK) return retval; retval = core_move_long_to_r2(target, HFM_BASE_ADDR); /* FM base address to r2 */