Øyvind Harboe
6fa4c5a456
disassembly: fix access to undefined memory pointer upon unknown instruction
...
return error message instead. Found by clang.
Change-Id: Ica109d077206236a12d007e77cc78061ffd05834
Signed-off-by: Øyvind Harboe <oyvind.harboe@zylin.com >
Reviewed-on: http://openocd.zylin.com/169
Tested-by: jenkins
Reviewed-by: Spencer Oliver <spen@spen-soft.co.uk >
2011-11-07 20:37:11 +00:00
Øyvind Harboe
3bab899063
xsvf: add missing error propagation
...
Change-Id: Ibc70deb980d6d18ceb376b72d9104e6180b16acf
Signed-off-by: Øyvind Harboe <oyvind.harboe@zylin.com >
Reviewed-on: http://openocd.zylin.com/176
Tested-by: jenkins
Reviewed-by: Spencer Oliver <spen@spen-soft.co.uk >
2011-11-07 20:35:42 +00:00
Øyvind Harboe
0552c05ee8
dsp5680xx: fix warnings
...
- propagate error
- remove dead assignment
Change-Id: I0d7078f531d96e421e95f08bfd908e818500d74c
Signed-off-by: Øyvind Harboe <oyvind.harboe@zylin.com >
Reviewed-on: http://openocd.zylin.com/170
Tested-by: jenkins
Reviewed-by: Spencer Oliver <spen@spen-soft.co.uk >
2011-11-07 20:34:41 +00:00
Øyvind Harboe
d931bb5a05
str9x: explain compiler that a local variable will always be initialized
...
Change-Id: I9ddb2793b4cdbf6acea6f69973531491e4ebcc5b
Signed-off-by: Øyvind Harboe <oyvind.harboe@zylin.com >
Reviewed-on: http://openocd.zylin.com/145
Tested-by: jenkins
Reviewed-by: Spencer Oliver <spen@spen-soft.co.uk >
2011-11-07 20:33:17 +00:00
Øyvind Harboe
00c8648351
at91sam3: fix warnings
...
- reduce scope of variables
- assert on post condition to fix clang warning
Change-Id: Id91038f73a632f9688ba52c9c34eae923626e770
Signed-off-by: Øyvind Harboe <oyvind.harboe@zylin.com >
Reviewed-on: http://openocd.zylin.com/160
Tested-by: jenkins
Reviewed-by: Spencer Oliver <spen@spen-soft.co.uk >
2011-11-07 20:32:51 +00:00
Øyvind Harboe
4bea65f1b2
str7x: fix error propagation
...
stick to convention of "retval" being used as error value to
be propagated and use "flash_flags" local variable for flash
flags read from how.
Change-Id: I63f1f2248b4f4538d6cd7634ae277f7c0aadc346
Signed-off-by: Øyvind Harboe <oyvind.harboe@zylin.com >
Reviewed-on: http://openocd.zylin.com/178
Tested-by: jenkins
Reviewed-by: Spencer Oliver <spen@spen-soft.co.uk >
2011-11-07 20:32:06 +00:00
Uwe Hermann
ca45e700b1
target config files: Fix whitespace issues.
...
Drop useless double-space occurences, drop trailing whitespace, and fix
some other minor whitespace-related issues.
Change-Id: I6b4c515492e2ee94dc25ef1fe4f51015a4bba8b5
Signed-off-by: Uwe Hermann <uwe@hermann-uwe.de >
Signed-off-by: Spencer Oliver <spen@spen-soft.co.uk >
Reviewed-on: http://openocd.zylin.com/137
Tested-by: jenkins
2011-11-07 16:16:33 +00:00
Øyvind Harboe
17b546a900
ecos: add missing error propagation
...
Change-Id: Ib34815c9cf654517f22486a7c8001fdb7471338c
Signed-off-by: Øyvind Harboe <oyvind.harboe@zylin.com >
Reviewed-on: http://openocd.zylin.com/174
Tested-by: jenkins
Reviewed-by: Spencer Oliver <spen@spen-soft.co.uk >
2011-11-07 16:14:47 +00:00
Øyvind Harboe
6be4646d17
xscale: cleanup
...
- fix error propagation
- add some debug output for "unused" variables
- reduce scope of variable to avoid "unread" variables.
Change-Id: I136995f2a043102e64b8fff3017502fae564013b
Signed-off-by: Øyvind Harboe <oyvind.harboe@zylin.com >
Reviewed-on: http://openocd.zylin.com/175
Tested-by: jenkins
Reviewed-by: Spencer Oliver <spen@spen-soft.co.uk >
2011-11-07 16:13:08 +00:00
Øyvind Harboe
b01e136045
warning fix: add self-consitency check to remove warning
...
verify promise of code that more code can be pasted with an
assert at the end condition of the code passage that builds
string.
Change-Id: I76a4e5f91b9142fff932e1493cb43c29eb6a0f80
Signed-off-by: Øyvind Harboe <oyvind.harboe@zylin.com >
Reviewed-on: http://openocd.zylin.com/143
Tested-by: jenkins
Reviewed-by: Øyvind Harboe <oyvindharboe@gmail.com >
2011-11-05 12:01:30 +00:00
Øyvind Harboe
61699628c8
cfi: fix gaffe in fixing warnings
...
introduced reading garbage value for arm32.
Change-Id: Ib5792a8a3207ee4db6d01d354df98c3cfabce037
Signed-off-by: Øyvind Harboe <oyvind.harboe@zylin.com >
Reviewed-on: http://openocd.zylin.com/162
Tested-by: jenkins
Reviewed-by: Spencer Oliver <spen@spen-soft.co.uk >
2011-11-04 22:53:31 +00:00
Spencer Oliver
e875e321f1
tools: fix permissions
...
Change-Id: I9419138dd2972304daf215594ca917ac8eb7fcda
Signed-off-by: Spencer Oliver <spen@spen-soft.co.uk >
2011-11-04 10:00:30 +00:00
Spencer Oliver
45570860d0
tools: add checkpatch script
...
execute from openocd root dir after commiting change but before
pushing to gerrit.
tools/checkpatch.sh
This is the same script used by the jenkins build server to validate
a change.
Change-Id: Ib40d44b160e1c50a5e47ab55fc48a554381ea763
Signed-off-by: Spencer Oliver <spen@spen-soft.co.uk >
Reviewed-on: http://openocd.zylin.com/167
Tested-by: jenkins
2011-11-04 09:56:22 +00:00
Øyvind Harboe
482e8a2b55
etm: fix warning by removing assignment that is immediately overwritten
...
Change-Id: Ia3a83d3c1fc3a1707d69017fce6cf142a81babc4
Signed-off-by: Øyvind Harboe <oyvind.harboe@zylin.com >
Reviewed-on: http://openocd.zylin.com/165
Tested-by: jenkins
Reviewed-by: Spencer Oliver <spen@spen-soft.co.uk >
2011-11-04 09:15:14 +00:00
Øyvind Harboe
ed028542ed
cortex_m: initialize unused CPU variables to 0 for poll info output
...
fixes warnings.
Change-Id: I1a9ec09083d4e6269889fb79e6121f25e83eb396
Signed-off-by: Øyvind Harboe <oyvind.harboe@zylin.com >
Reviewed-on: http://openocd.zylin.com/163
Tested-by: jenkins
Reviewed-by: Spencer Oliver <spen@spen-soft.co.uk >
2011-11-04 09:13:14 +00:00
Øyvind Harboe
5bdd2111d0
dsp5680xx: add missing and broken error propagation
...
found by clang.
Change-Id: Ie7e2ecad71bf0838ece93727e4778ad368b890ef
Signed-off-by: Øyvind Harboe <oyvind.harboe@zylin.com >
Reviewed-on: http://openocd.zylin.com/156
Tested-by: jenkins
Reviewed-by: Spencer Oliver <spen@spen-soft.co.uk >
2011-11-04 09:06:50 +00:00
Øyvind Harboe
2b20e4afac
at91sam9: fix broken error propagation
...
Change-Id: I3288ce6f7642e519c26dd099be888a395fe1de94
Signed-off-by: Øyvind Harboe <oyvind.harboe@zylin.com >
Reviewed-on: http://openocd.zylin.com/159
Tested-by: jenkins
Reviewed-by: Spencer Oliver <spen@spen-soft.co.uk >
2011-11-04 09:05:47 +00:00
Øyvind Harboe
cb38df20dc
avr32_regs: add missing error propagation
...
Change-Id: Ie8b141dd534d73eccfc045069d5f628bd1eea88e
Signed-off-by: Øyvind Harboe <oyvind.harboe@zylin.com >
Reviewed-on: http://openocd.zylin.com/166
Tested-by: jenkins
Reviewed-by: Spencer Oliver <spen@spen-soft.co.uk >
2011-11-04 09:05:15 +00:00
Uwe Hermann
d031b5def8
interface configs: Add missing URLs and names.
...
Also, drop author name from interface/hilscher_* files, that info is in the
git log, and none of the other files contain author names either.
Change-Id: Idf0eb4279c4bff31d15c166619c0bf8b1c5bb877
Signed-off-by: Uwe Hermann <uwe@hermann-uwe.de >
Reviewed-on: http://openocd.zylin.com/138
Tested-by: jenkins
Reviewed-by: Spencer Oliver <spen@spen-soft.co.uk >
2011-11-03 23:53:26 +00:00
Øyvind Harboe
61957bee47
HACKING: all you need is http access
...
Change-Id: I191c1da5126c4c9ea1ff8826576b6b24feaf9881
Signed-off-by: Øyvind Harboe <oyvind.harboe@zylin.com >
Reviewed-on: http://openocd.zylin.com/157
Tested-by: jenkins
Reviewed-by: Øyvind Harboe <oyvindharboe@gmail.com >
Reviewed-by: Spencer Oliver <spen@spen-soft.co.uk >
2011-11-03 23:46:14 +00:00
Spencer Oliver
ce3905a29f
checkpatch: increase line length warning to 100
...
Change-Id: Ief0445ea6581929b3ffdcf8bc644ce5f27b392c4
Signed-off-by: Spencer Oliver <spen@spen-soft.co.uk >
2011-11-03 23:09:05 +00:00
Spencer Oliver
efbafd9dc8
tools: add checkpatch script
...
Change-Id: I3579028fc1c6ee8bea58c82e5f0eecba7794d7cb
Signed-off-by: Spencer Oliver <spen@spen-soft.co.uk >
2011-11-03 19:22:19 +00:00
Øyvind Harboe
bab6db1fd9
gdb_server: assert to avoid malloc(0)
...
Change-Id: I6ae3e007f4aa768f8bc64de78351750138f12e53
Signed-off-by: Øyvind Harboe <oyvind.harboe@zylin.com >
Reviewed-on: http://openocd.zylin.com/135
Tested-by: jenkins
Reviewed-by: Andreas Fritiofson <andreas.fritiofson@gmail.com >
Reviewed-by: Øyvind Harboe <oyvindharboe@gmail.com >
2011-11-03 11:16:16 +00:00
Spencer Oliver
252758b6a1
cfg: add Stellaris LM4F232 Evaluation Kit config
...
Change-Id: Ica754897bef6573a0738ed1afdfe1dfda07292fd
Signed-off-by: Spencer Oliver <spen@spen-soft.co.uk >
Reviewed-on: http://openocd.zylin.com/151
Tested-by: jenkins
Reviewed-by: Andreas Fritiofson <andreas.fritiofson@gmail.com >
2011-11-02 23:32:03 +00:00
Spencer Oliver
07be858d2a
cfg: add Blizzard class to stellaris.cfg
...
Change-Id: I2a1320c696b6d9b070e4a927c4cd4d68178af751
Signed-off-by: Spencer Oliver <spen@spen-soft.co.uk >
Reviewed-on: http://openocd.zylin.com/150
Tested-by: jenkins
Reviewed-by: Andreas Fritiofson <andreas.fritiofson@gmail.com >
2011-11-02 23:30:06 +00:00
Mark Vels
444f202360
tx27stk5: add board init support for KaRo TX27 CPU module
...
This patch adds support for a KaRo TX27 CPU module on a StarterkitV base board.
The register settings have been extracted from a RedBoot distribution
that is distributed along with the hardware by KaRo.
This setup has been tested with a JTAGKey. The testing has been focussed
on loading a program into memory and start execution.
Although the flash seems to be correctly detected, no effort has been put
in testing the NAND programming yet.
Change-Id: Ib17763f1e3ecacd0eb9b5fdc32f8cba7a5e59be5
Signed-off-by: Mark Vels <mark.vels@team-embedded.nl >
Reviewed-on: http://openocd.zylin.com/158
Tested-by: jenkins
Reviewed-by: Spencer Oliver <spen@spen-soft.co.uk >
2011-11-02 14:57:52 +00:00
Øyvind Harboe
955316a727
fix warning: remove assigned to variable
...
variable is subsequently not used
Change-Id: I177d21c6ba9f1f2e3765feffdbf317ea375a8cfe
Signed-off-by: Øyvind Harboe <oyvind.harboe@zylin.com >
Reviewed-on: http://openocd.zylin.com/149
Tested-by: jenkins
Reviewed-by: Spencer Oliver <spen@spen-soft.co.uk >
2011-11-02 09:44:08 +00:00
Øyvind Harboe
2c906384c3
cortex_a: add missing error propagation
...
found by clang.
Change-Id: I50eac219d7540fd48d3285f3f213cb659492d0c0
Signed-off-by: Øyvind Harboe <oyvind.harboe@zylin.com >
Reviewed-on: http://openocd.zylin.com/153
Tested-by: jenkins
Reviewed-by: Spencer Oliver <spen@spen-soft.co.uk >
2011-11-02 09:43:04 +00:00
Øyvind Harboe
5f00c007cb
usbtoxxx: remove warning by reducing scope of variable
...
Change-Id: Icc3cfe601082cd83ad1c8818c1e21e7ada014150
Signed-off-by: Øyvind Harboe <oyvind.harboe@zylin.com >
Reviewed-on: http://openocd.zylin.com/154
Tested-by: jenkins
Reviewed-by: Spencer Oliver <spen@spen-soft.co.uk >
2011-11-02 09:42:34 +00:00
Øyvind Harboe
566faa17de
arm11: print next address to debug
...
fixes clang warning. Basically the next address pointer is not
used for anything in the fn, except to be examined in debug.
Change-Id: I253519b8e49e54490bbe7da8ec3d2dd31f49052a
Signed-off-by: Øyvind Harboe <oyvind.harboe@zylin.com >
Reviewed-on: http://openocd.zylin.com/155
Tested-by: jenkins
Reviewed-by: Spencer Oliver <spen@spen-soft.co.uk >
2011-11-02 09:41:40 +00:00
Øyvind Harboe
2ea7a42e22
cortex_m: add missing error checking
...
found by clang.
Change-Id: I099c6fe6b044dba36c20221cb439bdcba5a6bb6f
Signed-off-by: Øyvind Harboe <oyvind.harboe@zylin.com >
Reviewed-on: http://openocd.zylin.com/152
Tested-by: jenkins
Reviewed-by: Peter Stuge <peter@stuge.se >
2011-11-01 22:12:59 +00:00
Øyvind Harboe
06216744ed
target: fix null pointer exception
...
check if no target is selected and return error.
Change-Id: Ie8abb63c708d09572b45e88fc6766af108715077
Signed-off-by: Øyvind Harboe <oyvind.harboe@zylin.com >
Reviewed-on: http://openocd.zylin.com/148
Tested-by: jenkins
Reviewed-by: Spencer Oliver <spen@spen-soft.co.uk >
2011-11-01 21:20:19 +00:00
Spencer Oliver
889a306fc8
flash: add Stellaris Blizzard class
...
Change-Id: I83f0d6edf3ab31d9fa86682f20cec77dc47ba2f6
Signed-off-by: Spencer Oliver <spen@spen-soft.co.uk >
Reviewed-on: http://openocd.zylin.com/146
Tested-by: jenkins
Reviewed-by: Andreas Fritiofson <andreas.fritiofson@gmail.com >
2011-11-01 19:45:33 +00:00
Spencer Oliver
3f8f583964
target: rename cortex_m3.[ch] to cortex_m.[ch]
...
This rename is in preparation for cortex_m4 support.
Change-Id: Ic08c298ec6ed2aabc2c39db67191f68b3a51f550
Signed-off-by: Spencer Oliver <spen@spen-soft.co.uk >
Reviewed-on: http://openocd.zylin.com/147
Tested-by: jenkins
Reviewed-by: Øyvind Harboe <oyvindharboe@gmail.com >
2011-11-01 14:23:08 +00:00
Øyvind Harboe
01f461b20a
warning fix: remove senseless assignment before bailing out of fn w/error
...
Change-Id: I822f3adce0eccb880007673d60c7eccf7d36b398
Signed-off-by: Øyvind Harboe <oyvind.harboe@zylin.com >
Reviewed-on: http://openocd.zylin.com/144
Tested-by: jenkins
Reviewed-by: Peter Stuge <peter@stuge.se >
2011-10-31 21:12:30 +00:00
Øyvind Harboe
9b9092b7fa
warnings: null pointer check fix
...
rewrite broken null pointer check code by reducing scope
of variable.
Change-Id: I8254f6849b187e5c9cd083053cdc11973c6fe339
Signed-off-by: Øyvind Harboe <oyvind.harboe@zylin.com >
Reviewed-on: http://openocd.zylin.com/142
Tested-by: jenkins
Reviewed-by: Spencer Oliver <spen@spen-soft.co.uk >
2011-10-31 20:43:36 +00:00
Øyvind Harboe
9933fa334d
cfi: unsupported code paths now report and return error
...
found by clang, would have done something undefined and mysterious
later on.
Change-Id: If7d7aca8514575d229ed0b17378bf8b1bbf347c4
Signed-off-by: Øyvind Harboe <oyvind.harboe@zylin.com >
Reviewed-on: http://openocd.zylin.com/133
Tested-by: jenkins
Reviewed-by: Spencer Oliver <spen@spen-soft.co.uk >
2011-10-31 20:41:18 +00:00
Øyvind Harboe
08815946f6
bugfixes: tinker a bit with the targets command
...
return error when target can not be found instead of ERROR_OK,
split fn.
Change-Id: Iba5232d3862a490d0995c3bfece23685bd6856e3
Signed-off-by: Øyvind Harboe <oyvind.harboe@zylin.com >
Reviewed-on: http://openocd.zylin.com/131
Tested-by: jenkins
Reviewed-by: Spencer Oliver <spen@spen-soft.co.uk >
2011-10-31 17:41:44 +00:00
Øyvind Harboe
fc553327c0
dsp563xxx: fix missing error propagation found by clang
...
Change-Id: I7380ce145b4942e21b174f2a810928a877c32bc7
Signed-off-by: Øyvind Harboe <oyvind.harboe@zylin.com >
Reviewed-on: http://openocd.zylin.com/140
Tested-by: jenkins
Reviewed-by: Spencer Oliver <spen@spen-soft.co.uk >
2011-10-31 11:04:42 +00:00
Uwe Hermann
c0e1bfa8b4
interface configs: Fix whitespace and other issues.
...
Change-Id: I98825c7fb9bdee75b69b06005ed12a3f64ec4db4
Signed-off-by: Uwe Hermann <uwe@hermann-uwe.de >
Reviewed-on: http://openocd.zylin.com/139
Tested-by: jenkins
Reviewed-by: Peter Stuge <peter@stuge.se >
2011-10-30 02:06:07 +00:00
Uwe Hermann
abfd4b19a6
config files: Drop incorrect comments.
...
There are many "force an error till we get a good number" comments in
target/board files. This refers to the use-case where a config script
sets _CPUTAPID to 0xffffffff (which presumely gets overridden later):
if { [info exists CPUTAPID ] } {
set _CPUTAPID $CPUTAPID
} else {
# Force an error until we get a good number.
set _CPUTAPID 0xffffffff
}
However, the same comment was also copy-pasted in many files which do
_not_ set _CPUTAPID to 0xffffffff, where the comment doesn't make any
sense at all. Drop those comments. Also, add one missing comment, and
fix small whitespace and grammar issues.
Change-Id: Ic4ba3b5ccba87ed40cea0d6a7d66609fbdfa3c71
Signed-off-by: Uwe Hermann <uwe@hermann-uwe.de >
Reviewed-on: http://openocd.zylin.com/136
Tested-by: jenkins
Reviewed-by: Peter Stuge <peter@stuge.se >
2011-10-30 01:57:33 +00:00
Øyvind Harboe
fe2fd812fa
clang: fix warning by adding assert that shows that a variable is used
...
Change-Id: I26e0ba9f1ae9d43c9a14c42c4225746782dc4d66
Signed-off-by: Øyvind Harboe <oyvind.harboe@zylin.com >
Reviewed-on: http://openocd.zylin.com/134
Tested-by: jenkins
Reviewed-by: Øyvind Harboe <oyvindharboe@gmail.com >
2011-10-29 13:13:45 +00:00
Jonathan Dumaresq
af51c69fbc
Fixes comment typo for page size
...
Change-Id: I6dd8aadcecd680c48e696aeec0daf74d2addbb05
Signed-off-by: Jonathan Dumaresq <jdumaresq@cimeq.qc.ca >
Reviewed-on: http://openocd.zylin.com/132
Tested-by: jenkins
Reviewed-by: Peter Stuge <peter@stuge.se >
2011-10-28 15:24:50 +00:00
Øyvind Harboe
97806831e2
bugfixes: numerous bugs in error propagation found by clang
...
Change-Id: I784068325b422d1918e28c08544bc5a1332d712f
Signed-off-by: Øyvind Harboe <oyvind.harboe@zylin.com >
Reviewed-on: http://openocd.zylin.com/130
Tested-by: jenkins
Reviewed-by: Øyvind Harboe <oyvindharboe@gmail.com >
2011-10-27 22:08:35 +00:00
Øyvind Harboe
7e817839f3
clang: fix warning about missing check for return value
...
Change-Id: I0c6b6b8d1f0c30b6a503cb98df30584252bc0ee1
Signed-off-by: Øyvind Harboe <oyvind.harboe@zylin.com >
Reviewed-on: http://openocd.zylin.com/129
Tested-by: jenkins
Reviewed-by: Øyvind Harboe <oyvindharboe@gmail.com >
2011-10-27 17:38:46 +00:00
Jim Norris
d265fa78c3
Remove use of undefined variable.
...
Change-Id: Id8fd345438c360b2a42857525f05360ce2794d21
Signed-off-by: Jim Norris <u17263@att.net >
Reviewed-on: http://openocd.zylin.com/127
Reviewed-by: Peter Stuge <peter@stuge.se >
Tested-by: jenkins
2011-10-27 00:47:22 +00:00
Øyvind Harboe
e6d979eefc
clang: fix warning about use of unitialized variable
...
this was a false positive, silence it.
Change-Id: I432e0c466c94cf8fd6bbf0ea153c8501a8a261eb
Signed-off-by: Øyvind Harboe <oyvind.harboe@zylin.com >
Reviewed-on: http://openocd.zylin.com/126
Tested-by: jenkins
Reviewed-by: Spencer Oliver <spen@spen-soft.co.uk >
2011-10-26 20:36:04 +00:00
Jim Norris
2036c2aaae
Add configuration for ATMEL SAM3N-EK board.
...
Change-Id: I525f6c346cace4e54f47659c5a7aceb29ee4baf2
Signed-off-by: Jim Norris <u17263@att.net >
Reviewed-on: http://openocd.zylin.com/125
Tested-by: jenkins
Reviewed-by: Øyvind Harboe <oyvindharboe@gmail.com >
2011-10-26 20:31:45 +00:00
Jim Norris
be17f6b08e
Add configuration for ATMEL SAM3N series.
...
Change-Id: Iac498ab37e59127b989f29a1c4167ab29d625b05
Signed-off-by: Jim Norris <u17263@att.net >
Reviewed-on: http://openocd.zylin.com/124
Tested-by: jenkins
Reviewed-by: Øyvind Harboe <oyvindharboe@gmail.com >
2011-10-26 20:31:02 +00:00
Marti Bolivar
5cca45d5f9
stm3220g_eval.cfg: fix CHIPNAME.
...
The STM3220G-EVAL board has an STM32F207IGH6. ("...H6", not "...T6").
Change-Id: Iaf3dae6830c5c0685a1dcd1588d391434bc51be7
Signed-off-by: Marti Bolivar <mbolivar@leaflabs.com >
Reviewed-on: http://openocd.zylin.com/120
Tested-by: jenkins
Reviewed-by: Spencer Oliver <spen@spen-soft.co.uk >
2011-10-25 20:08:58 +00:00