0ffbc60333
Factor load_image argument parsing to parse_load_image_command_args: - Make fast_load_image use the helper coverage the standard load_image. - Improve whitespace in the moved lines.
zwelch
2009-06-13 00:34:31 +00:00
af52480a45
Improve handle_profile_command argument parsing: - Use parse_uint to ensure timeout value parses properly.
zwelch
2009-06-13 00:34:24 +00:00
b7c5e630ea
Improve handle_virt2phys_command argument parsing: - Use parse_u32 to ensure virtual address parses properly.
zwelch
2009-06-13 00:34:17 +00:00
f7afcfe23f
Cleanup and improve handle_wp_command and handle_rwp_command: - Simplify argument parsing logic using switch statement. - Use parse_u32 to ensure all values parse properly. - Return syntax error when mode argument fails to parse.
zwelch
2009-06-13 00:34:10 +00:00
d0a300e0a0
Improve and simplify handle_bp_command and handle_rbp_command: - Bug fix: return syntax error if remove called without one argument. - Use parse_u32 to ensure address and length arguments parse properly.
zwelch
2009-06-13 00:34:03 +00:00
16c77cf3ca
Improve handle_verify_image_command_internal command argument handling: - Use parse_u32 to ensure address parses properly.
zwelch
2009-06-13 00:33:55 +00:00
890973acc4
Improve handle_dump_image_command argument parsing: - Use parse_u32 to ensure address and size parse properly.
zwelch
2009-06-13 00:33:48 +00:00
bb37adadab
Improve handle_load_image_command argument parsing: - Use parse_u32 to ensure base/min/max addresses parse properly.
zwelch
2009-06-13 00:33:42 +00:00
6f9aac1892
Improve handle_mw_command argument handling: - Change: All local variable types are now unsigned. - Use parse_u32 to ensure address and value parse properly. - Use parse_uint to ensure count parses properly. - Move variables to location of first use.
zwelch
2009-06-13 00:33:34 +00:00
08128b572a
Improve handle_md_command argument handling: - Use parse_u32 and parse_uint for address and count, respectively.
zwelch
2009-06-13 00:33:25 +00:00
71f95de8a6
Use parse_u32 in handle_resume_command and handle_step_command.
zwelch
2009-06-13 00:33:18 +00:00
5d0cdf4d94
Cleanup and improve handle_halt_command: - Make argument check use parse_uint to ensure value parses properly. - Move variable declarations to location of first use.
zwelch
2009-06-13 00:33:11 +00:00
fad8521a87
Cleanup and fi handle_wait_halt_command: - Use unsigned type for delay variable. - Use parse_uint to ensure delay argument parses properly. - Bug fix: Return syntax error if more than one argument is given. - Bug fix: Return syntax error when argument fails to parse.
zwelch
2009-06-13 00:33:01 +00:00
45ec363c4a
Use parse_uint in handle_reg_command to ensure reg number parses properly.
zwelch
2009-06-13 00:32:54 +00:00
2343245090
Use parse_uint in get_target to ensure target id is parsed properly.
zwelch
2009-06-13 00:32:40 +00:00
7fdce0e8bc
Further cleanup to MIPS target read/write memory function: - Move the mips32_..._read_mem calls to top-level of read_mem function. - Change: Only perform mips_m4k_read_mem conversion when retval == ERROR_OK. - Prevents pointless conversions of bogus read values after failures. - Eliminate retval variable from mips_m4k_write_mem; return directly. - Move declaration of retval variable to point of first use. - Remove the now redundant switch statements testing size: - argument sanitizing already covers these cases.
zwelch
2009-06-12 04:14:28 +00:00
a351c57261
Fix unitialized use of cur_speed in handle_jtag_khz_command: - Use the default KHz speed setting, in case interface is not initialized.
zwelch
2009-06-12 01:41:07 +00:00
f5e4511701
Improve vsllink command argument handling: - Bug fix: Always clear high bit of USB bulk out endpoint. - Use parse_ulong helpers to ensure numeric strings are parsed properly.
zwelch
2009-06-12 01:41:00 +00:00
a9d5119825
Improve handle_runtest_command: - Use parse_uint helper to ensure argument is parsed properly.
zwelch
2009-06-12 01:40:54 +00:00
ea95cdb8e2
Improve VID/PID command argument handling in FTDI driver: - Bug fix: Return a syntax error when less than two arguments are given. - Bug fix: Use parse_u16 helper to ensure vales are parsed properly. - Simplify loop termination logic by ensuring argc is always even. - Move loop induction variable declaration to where it is used.
zwelch
2009-06-12 01:40:48 +00:00
70d853b9fa
Improve handle_irscan_command: - Use parse_u32 helper to ensure scan values are parsed properly. - Clear the fields buffer to ensure partial cleanup occur correctly.
zwelch
2009-06-12 01:40:42 +00:00
82403fe644
Improve JTAG reset, speed, and khz handlers to use parse_uint helper.
zwelch
2009-06-12 01:40:35 +00:00
5d657571cb
Use parse_uint helper to replace strtoul call in jtag_tap_by_string.
zwelch
2009-06-12 01:40:29 +00:00
d5339d2eb4
Simplify and improve gw16012_handle_parport_command: - Show the port number to the user when asking for it or setting it. - Print an error if the parport_port has already been set. - Use parse_u16 helper to ensure the parport_port string parses correctly.
zwelch
2009-06-12 01:40:23 +00:00
f218f36df5
Simplify and improve amt_jtagaccel_handle_parport_port_command: - Show the port number to the user when asking for it or setting it. - Print an error if the amt_jtagaccel_port has already been set. - Use parse_u16 helper to ensure amt_jtagaccel_port string parses correctly.
zwelch
2009-06-12 01:40:17 +00:00
ae28b96ab9
Simplify and improve parport_handle_parport_port_command: - Show the port number to the user when asking for it or setting it. - Print an error if the parport_port has already been set. - Use parse_u16 helper to ensure the parport_port string parses correctly.
zwelch
2009-06-12 01:40:03 +00:00
0f6a47837e
Simplify and improve handle_debug_level_comamnd: - Bug fix: Return a syntax error if more than one argument is given. - Bug fix: Use new parse_uint helper ensure debug_level parses correctly. - Change: Display the debug_level after it has been set. - Simplify bounds checking of debug_level.
zwelch
2009-06-12 01:39:57 +00:00
5af1bdcff4
Simplify handle_sleep_command: - Use new parse_ulong to ensure duration parses as a valid number. - Rework logic to improve readability and seliminate uperfluous braces. - Change whitespace to improve style.
zwelch
2009-06-12 01:39:51 +00:00
5c123481a1
Add new parse_uinttype wrappers for strtoul in src/helper/command.[ch]. - Used to improve command argument parsing of unsigned integers values.
zwelch
2009-06-12 01:39:44 +00:00
2e0be4e18b
- fix bug introduced during r1962 - Original patch submitted by David Claffey [dnclaffey@gmail.com].
ntfreak
2009-06-11 19:32:10 +00:00
eb9ecb8224
embedded host: launch telnet server even if configuration fails
oharboe
2009-06-11 13:03:32 +00:00
1b2c1c6ff0
fix ordering of arguments to fwrite()
oharboe
2009-06-11 13:00:08 +00:00
538050c146
Factor handle_bp_command into pieces: - Bug fix: return a syntax error if the wrong number of arguments are given. - Add handle_bp_command_list() and handle_bp_command_set(). - Use temporary addr variable to eliminate redundant strtoul() calls. - Place variable declarations at their point of first use.
zwelch
2009-06-11 11:43:07 +00:00
8e899d43ef
Factor target_timer_callbacks_check_time into pieces: - Add target_timer_callback_periodic_restart and target_call_timer_callback. - Clean up and simplify logic that determines whether to call each callback. - Move variable declarations to location of first use.
zwelch
2009-06-11 11:43:00 +00:00
7c892082c9
Simplify and clean handle_virt2phys_command: - Add a doxygen block to simplify logic. - Move declarations to point of first use.
zwelch
2009-06-11 11:42:54 +00:00
57612ecf1d
Simplify and fix target handle_rwp_command routine: - Return syntax error unless exactly one argument is passed. - Move variable declaration to point of first use.
zwelch
2009-06-11 11:42:47 +00:00
d7ada2457e
Simplify and fix handle_reset_command: - Return syntax error if more than one argument is given. - Move variables to location of first use.
zwelch
2009-06-11 11:42:40 +00:00
e4850d7159
Simplify handle_resume_command: - Eliminate redundant calls to target_resume with addr temp variable. - Place variables at location of first use. - Fix minor whitespace issues.
zwelch
2009-06-11 11:42:33 +00:00
78cf92166a
Simplify and fix handle_step_command: - Bug fix: return syntax error when more than one argument is given. - Eliminate redundant calls to step callback with addr temp variable. - Place variables at location of first use.
zwelch
2009-06-11 11:42:26 +00:00
4c31d5d179
Move jtag_get_flush_queue_count near jtag_execute_queue (fix its docs).
zwelch
2009-06-11 07:08:45 +00:00
128ff94226
Improve grouping of JTAG KHz and verification accessors in header file. Add some quick Doxygen comments for these routines.
zwelch
2009-06-11 07:08:34 +00:00
28fa603eff
Group JTAG reset configuration and accessor APIs together in header file. Remove unused reset_line_mode enumerated type.
zwelch
2009-06-11 07:08:28 +00:00
5208481fb3
Move jtag_error helper declarations to the end of the header.
zwelch
2009-06-11 07:08:21 +00:00
08382e0601
Out-of-line jtag_tap_next_enabled and simplify its logic.
zwelch
2009-06-11 07:08:14 +00:00
bdb7dd5e0f
Move the documentation for the "poll" command up with other server configuration. Explain what it's about; reference the related "$target_name curstate" method.
zwelch
2009-06-10 04:06:25 +00:00
82aa9af1ad
Improve use of automake conditionals for FTDI-based JTAG drivers: - Remove once-used XXX_FTD2XX symbols; replace with XXX_DRIVER symbols. - Enabled when either libftdi or FTD2xx driver should be built. - Eliminates redundant DRIVERSFILE assignment in JTAG automake input.
zwelch
2009-06-09 14:18:28 +00:00
0bc53e73cc
Simplify JTAG automake input file: - Consolidate all individual driver variables into DRIVERFILES. - Eliminates all empty 'else' conditional clauses. - Move minidriver files to top of file. - Use MINIDRIVER conditional to build only driver(s) that will be linked. - Eliminate superfluous whitespace.
zwelch
2009-06-09 14:18:23 +00:00
b8034bd9ee
Rename jtag_driver.c as driver.c to remove duplicate name component.
zwelch
2009-06-09 12:47:49 +00:00
9d19468502
Add a rule to rebuild libtool if ltmain.sh changes (from libtool docs).
zwelch
2009-06-09 12:01:56 +00:00
e582ea9776
reset to eol native for now. guess-rev.sh was broken by eol native, but it was a red herring that these two files were affected.
oharboe
2009-06-09 11:05:45 +00:00
00228aa839
Fix make maintainer-clean for out-of-tree builds.
zwelch
2009-06-09 10:28:16 +00:00
e8febc2255
Encapsulate the core jtag interface pointer: - Add new jtag_config_khz to increase encapsulation of jtag->khz call. - Add new jtag_get_speed_readable to encapsulate of jtag->speed_div call. - Make definition of jtag static in core.c, remove extern from tcl.c.
zwelch
2009-06-09 10:07:07 +00:00
15974a0eeb
Continue encapsulation of JTAG event callback sub-API: - Move jtag_event_callbacks struct to core.c; it's an implementation detail. - Move jtag_*_event_callbacks next to the definition of the new function type.
zwelch
2009-06-09 08:41:36 +00:00
aabb31d571
Add jtag_event_handler_t: - Define the function signature used by the JTAG event callback mechanism. - Provide Doxygen block for new type, including TODO for its return value.
zwelch
2009-06-09 08:41:29 +00:00
ae52de5ad5
Expose jtag_unregister_event_callback with related API declarations.
zwelch
2009-06-09 08:41:23 +00:00
a485ded4bf
Improve encapsulation of JTAG event handling: - Move nvp_jtag_tap_event and jtag_tap_handle_event to tcl.c. - Change both to be static; remove declaration of function from jtag.h.
zwelch
2009-06-09 08:41:14 +00:00
55be316dbf
Cleanup and encapsulate IR Capture verification: - Add accessors for setting the jtag_verify_capture_ir flag. - Use them in handle_verify_ircapture_cpmmand - Change variable type to bool; make it static.
zwelch
2009-06-09 08:41:00 +00:00
a70d77aec3
Add missing static keywords to a few variables in JTAG core module.
zwelch
2009-06-09 08:40:54 +00:00
f9596e96c9
Move the jtag_error helper routines out of header file: - Makes jtag_error static, add new get helper function for completeness. - Improve and add documentation and style for these helpers.
zwelch
2009-06-09 08:40:46 +00:00
6dc2c2ce97
Encapsulate jtag_reset_config using accessors: - Update handle_reset_config_command in tcl.c to use new helpers. - Replace direct accesses in JTAG interface and target drivers.
zwelch
2009-06-09 08:40:31 +00:00
2a8e37173a
Remove superfluous extern for non-existant global variable.
zwelch
2009-06-09 08:40:23 +00:00
cd7f89f6bc
Add get and set accessors for jtag_speed: - Setter calls the interface driver callback to improve core encapsulation. - Use getter in standard JTAG interface drivers and ZY1000 minidriver.
zwelch
2009-06-09 08:40:10 +00:00
bcad121d2b
Encapsulate the jtag_event_callback list; add helper functions if needed.
zwelch
2009-06-09 08:40:02 +00:00
175867ea32
Encapsulate the jtag_trst and jtag_srst variables: - Add accessor functions to return their value. - Use new SRST accessor in cortex_m3.c and mips_m4k.c
zwelch
2009-06-09 08:39:50 +00:00
92a102c2d5
Move extern of nvp_jtag_tap_event from jtag.h to tcl.c.
zwelch
2009-06-09 08:39:44 +00:00
d19643f774
Remove superfluous extern of jtag_event_strings from jtag.h.
zwelch
2009-06-09 08:39:37 +00:00
7a53ff6633
remove native line style
oharboe
2009-06-09 07:51:47 +00:00
f5d2e29763
removed native line end style - breaks cygwin
oharboe
2009-06-09 06:53:26 +00:00
133a616572
Replace 'jtag.c' with 'core.c' in code comments.
zwelch
2009-06-09 04:54:09 +00:00
aed24a5946
Provide brief description of newly factored TCL layer in The Manual.
zwelch
2009-06-09 04:35:16 +00:00
66707c94d7
Split main jtag.c file into two layers: - src/jtag/core.c: contains the low-level JTAG TAP and scanning routines. - src/jtag/tcl.c: contains high-level JTAG TCL commands that use the core. - Remove static keywords from routines in core.c, extern from tcl.c: - jtag, jtag_interface global variables - jtag_{examine,validate}_chain and jtag_tap_{init,free} functions - Added myself to the copyright header in both of these files. - Used 'svn cp' to add files, so versioning was preserved for both.
zwelch
2009-06-09 04:15:13 +00:00
03b2b345ed
Merge documentation for jtag_add_statemove from source into header block.
zwelch
2009-06-09 02:48:28 +00:00
cf08b00376
Move Doxygen documentation for IR/DR scan routines to header file. - Move plain IR scan declaration closer to the other IR scan declarations.
zwelch
2009-06-09 02:48:18 +00:00
3cd428ffdb
- Replace 'jtag_tap_by_abs_position' with 'jtag_tap_by_position'.
zwelch
2009-06-09 02:24:05 +00:00
f7216ffa33
Remove non-existant jtag_tap_by_position API declaration.
zwelch
2009-06-09 02:24:00 +00:00
2410d4b2b9
Use unsigned type for jtag_tap_count and jtag_tap_by_abs_position.
zwelch
2009-06-09 02:23:53 +00:00
zwelch