auracaster/sw_openocd
3
0
Fork 0
forked from auracaster/openocd
Code Pull Requests Activity

flash: nand: prepare for aligning switch and case statements

Browse Source 
To prepare for aligning switch and case statements, fix in advance
some checkpatch error due to existing code:
- remove useless parenthesis;
- don't end line with an open parenthesis;
- expand multiple assignments.

While there, put the 'default' case as last in the list.

Change-Id: I17bf5e88b145ef9b5b188424182f4e54b818eeae
Signed-off-by: Antonio Borneo <borneo.antonio@gmail.com>
Reviewed-on: https://review.openocd.org/c/openocd/+/9011
Tested-by: jenkins
This commit is contained in:
Antonio Borneo
2025-06-28 10:34:00 +02:00
parent d123cfdc58
commit 1042a8d179
3 changed files with 10 additions and 11 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
src/flash/nand/core.c
View File

@@ -314,8 +314,7 @@ int nand_probe(struct nand_device *nand)
LOG_DEBUG("controller initialization failed"); LOG_DEBUG("controller initialization failed");
return ERROR_NAND_OPERATION_FAILED; return ERROR_NAND_OPERATION_FAILED;
case ERROR_NAND_OPERATION_NOT_SUPPORTED: case ERROR_NAND_OPERATION_NOT_SUPPORTED:
LOG_ERROR( LOG_ERROR("BUG: controller reported that it doesn't support default parameters");
"BUG: controller reported that it doesn't support default parameters");
return ERROR_NAND_OPERATION_FAILED; return ERROR_NAND_OPERATION_FAILED;
default: default:
LOG_ERROR("BUG: unknown controller initialization failure"); LOG_ERROR("BUG: unknown controller initialization failure");
@@ -474,11 +473,10 @@ int nand_probe(struct nand_device *nand)
LOG_DEBUG("controller initialization failed"); LOG_DEBUG("controller initialization failed");
return ERROR_NAND_OPERATION_FAILED; return ERROR_NAND_OPERATION_FAILED;
case ERROR_NAND_OPERATION_NOT_SUPPORTED: case ERROR_NAND_OPERATION_NOT_SUPPORTED:
LOG_ERROR( LOG_ERROR("controller doesn't support requested parameters (buswidth: %i, address cycles: %i, page size: %i)",
"controller doesn't support requested parameters (buswidth: %i, address cycles: %i, page size: %i)", nand->bus_width,
nand->bus_width, nand->address_cycles,
nand->address_cycles, nand->page_size);
nand->page_size);
return ERROR_NAND_OPERATION_FAILED; return ERROR_NAND_OPERATION_FAILED;
default: default:
LOG_ERROR("BUG: unknown controller initialization failure"); LOG_ERROR("BUG: unknown controller initialization failure");

2
src/flash/nand/mx3.c
View File

@@ -663,7 +663,7 @@ static int do_data_output(struct nand_device *nand)
/* /*
* ECC stuff * ECC stuff
*/ */
if ((mx3_nf_info->optype == MX3_NF_DATAOUT_PAGE) if (mx3_nf_info->optype == MX3_NF_DATAOUT_PAGE
&& mx3_nf_info->flags.hw_ecc_enabled) { && mx3_nf_info->flags.hw_ecc_enabled) {
uint16_t ecc_status; uint16_t ecc_status;
target_read_u16 (target, MX3_NF_ECCSTATUS, &ecc_status); target_read_u16 (target, MX3_NF_ECCSTATUS, &ecc_status);

7
src/flash/nand/tcl.c
View File

@@ -50,21 +50,22 @@ COMMAND_HANDLER(handle_nand_info_command)
int last = -1; int last = -1;
switch (CMD_ARGC) { switch (CMD_ARGC) {
default:
return ERROR_COMMAND_SYNTAX_ERROR;
case 1: case 1:
first = 0; first = 0;
last = INT32_MAX; last = INT32_MAX;
break; break;
case 2: case 2:
COMMAND_PARSE_NUMBER(int, CMD_ARGV[1], i); COMMAND_PARSE_NUMBER(int, CMD_ARGV[1], i);
first = last = i; first = i;
last = i;
i = 0; i = 0;
break; break;
case 3: case 3:
COMMAND_PARSE_NUMBER(int, CMD_ARGV[1], first); COMMAND_PARSE_NUMBER(int, CMD_ARGV[1], first);
COMMAND_PARSE_NUMBER(int, CMD_ARGV[2], last); COMMAND_PARSE_NUMBER(int, CMD_ARGV[2], last);
break; break;
default:
return ERROR_COMMAND_SYNTAX_ERROR;
} }
struct nand_device *p; struct nand_device *p;