From 96c219a40848710c8d94a08f235c12f4d6202c9e Mon Sep 17 00:00:00 2001 From: Antonio Borneo Date: Sun, 24 Aug 2025 12:30:52 +0200 Subject: [PATCH] drivers: ch347: fix scan-build warnings The newly merged driver ch347 triggers two new scan-build warnings about dead assignment to variables. Fix them. Change-Id: Ided14272c3573be1498584e68ac4653cde029f31 Signed-off-by: Antonio Borneo Fixes: 7d0e12589629 ("jtag/drivers: Add support for CH347-based JTAG adapters") Reviewed-on: https://review.openocd.org/c/openocd/+/9094 Tested-by: jenkins Reviewed-by: Matthias Jentsch Reviewed-by: Tomas Vanek --- src/jtag/drivers/ch347.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/src/jtag/drivers/ch347.c b/src/jtag/drivers/ch347.c index 8f563acaf..a0404a21f 100644 --- a/src/jtag/drivers/ch347.c +++ b/src/jtag/drivers/ch347.c @@ -863,7 +863,6 @@ static int ch347_single_read_get_byte(int read_buf_idx, uint8_t *byte) if (read_buf_idx > CH347_SINGLE_CMD_MAX_READ || read_buf_idx < 0) { LOG_ERROR("read_buf_idx out of range"); - read_buf_idx = 0; return ERROR_FAIL; } @@ -989,7 +988,6 @@ static int ch347_scratchpad_add_stableclocks(int count) } bool tms = ch347.tms_pin == TMS_H; - retval = ERROR_OK; for (int i = 0; i < count; i++) { retval = ch347_scratchpad_add_clock_tms(tms); if (retval != ERROR_OK)