auracaster/sw_openocd
3
0
Fork 0
forked from auracaster/openocd
Code Pull Requests Activity

target: add target->type->has_mmu fn.

Browse Source 
improve default target->read/write_phys_memory, produce
more sensible error messages if the mmu interface
functions have not been implemented yet vs. will
not be implemented(e.g. cortex m3).

Signed-off-by: Øyvind Harboe <oyvind.harboe@zylin.com>
This commit is contained in:
Øyvind Harboe
2009-10-27 14:02:16 +01:00
parent 972924b2ad
commit d269122f91
3 changed files with 48 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

38
src/target/target.c
View File

@@ -496,7 +496,13 @@ static int default_virt2phys(struct target_s *target, uint32_t virtual, uint32_t
static int default_mmu(struct target_s *target, int *enabled)
{
*enabled = 0;
LOG_ERROR("Not implemented.");
return ERROR_FAIL;
}
static int default_has_mmu(struct target_s *target, bool *has_mmu)
{
*has_mmu = true;
return ERROR_OK;
}
@@ -743,14 +749,32 @@ int target_mcr(struct target_s *target, int cpnum, uint32_t op1, uint32_t op2, u
static int default_read_phys_memory(struct target_s *target, uint32_t address, uint32_t size, uint32_t count, uint8_t *buffer)
{
LOG_ERROR("Not implemented");
return ERROR_FAIL;
int retval;
bool mmu;
retval = target->type->has_mmu(target, &mmu);
if (retval != ERROR_OK)
return retval;
if (mmu)
{
LOG_ERROR("Not implemented");
return ERROR_FAIL;
}
return target_read_memory(target, address, size, count, buffer);
}
static int default_write_phys_memory(struct target_s *target, uint32_t address, uint32_t size, uint32_t count, uint8_t *buffer)
{
LOG_ERROR("Not implemented");
return ERROR_FAIL;
int retval;
bool mmu;
retval = target->type->has_mmu(target, &mmu);
if (retval != ERROR_OK)
return retval;
if (mmu)
{
LOG_ERROR("Not implemented");
return ERROR_FAIL;
}
return target_write_memory(target, address, size, count, buffer);
}
@@ -816,6 +840,10 @@ int target_init(struct command_context_s *cmd_ctx)
{
target->type->mmu = default_mmu;
}
if (target->type->has_mmu == NULL)
{
target->type->has_mmu = default_has_mmu;
}
target = target->next;
}