auracaster/sw_openocd
3
0
Fork 0
forked from auracaster/openocd
Code Pull Requests Activity
5,484 Commits 3 Branches 34 Tags
fa39842d28460582b0c2db0d3fd3c4e2e892b960
Commit Graph

87 Commits

Author SHA1 Message Date
Spencer Oliver
c4f2a018a5 build: cleanup src/pld directory 
Change-Id: I9edb027c76e5d7fe21d557a11e6a9691fa581e86
Signed-off-by: Spencer Oliver <spen@spen-soft.co.uk>
Reviewed-on: http://openocd.zylin.com/408
Tested-by: jenkins
 2012-02-06 10:42:40 +00:00
Spencer Oliver
0c2f8b6eb8 cmd: add missing usage vars 
we should have caught them all - hopefully.

Change-Id: I35435317fccaf5ad0216244d69f76db6857bb582
Signed-off-by: Spencer Oliver <spen@spen-soft.co.uk>
Reviewed-on: http://openocd.zylin.com/381
Tested-by: jenkins
Reviewed-by: Øyvind Harboe <oyvindharboe@gmail.com>
 2012-01-18 21:45:02 +00:00
Mathias K
16b6b5e7a8 Change return value on error. 
On wrong parameters a error is signalized to the calling function.

Change-Id: I484443fdb39938e20382edc9246d5ec546a5c960
Signed-off-by: Mathias K <kesmtp@freenet.de>
Signed-off-by: Øyvind Harboe <oyvind.harboe@zylin.com>
Reviewed-on: http://openocd.zylin.com/282
Tested-by: jenkins
Reviewed-by: Øyvind Harboe <oyvindharboe@gmail.com>
 2012-01-04 17:56:46 +00:00
Øyvind Harboe
4668bd264c retire ERROR_INVALID_ARGUMENTS and replace with ERROR_COMMAND_SYNTAX_ERROR 
Change-Id: I6dee51e1fab1944085391f274a343cdb9014c7a4
Signed-off-by: Øyvind Harboe <oyvind.harboe@zylin.com>
Reviewed-on: http://openocd.zylin.com/300
Tested-by: jenkins
Reviewed-by: Øyvind Harboe <oyvindharboe@gmail.com>
Reviewed-by: Spencer Oliver <spen@spen-soft.co.uk>
 2012-01-04 17:13:46 +00:00
Freddie Chopin
f6315d5e5b Fix "unused variable" warnings (errors) detected with GCC 4.7.0 - trivial fixes 2011-06-04 09:35:13 +02:00
Øyvind Harboe
4f9a9b8eba warnings: use more 'const' for char * 
Signed-off-by: Øyvind Harboe <oyvind.harboe@zylin.com>
 2010-12-29 22:07:39 +01:00
Spencer Oliver
838cd58e24 build: add common.mk 
Rather than specifying common makefile variables move
them all to a common.mk.

Signed-off-by: Spencer Oliver <ntfreak@users.sourceforge.net>
 2010-11-18 14:05:56 +00:00
Øyvind Harboe
f6a3fc818b warnings: fix alignment warnings 
These warnings are for architectures that do not
support non-aligned word access.

Signed-off-by: Øyvind Harboe <oyvind.harboe@zylin.com>
 2010-09-20 13:12:35 +02:00
Antonio Borneo
4678108034 PLD: review scope of functions 
Add "static" qualifier to private functions.

Signed-off-by: Antonio Borneo <borneo.antonio@gmail.com>
 2010-04-10 17:06:16 +08:00
Øyvind Harboe
96949890ee jtag: move towards making out_value const 
These were relatively straightforward fixes which are
backwards compatible.

Signed-off-by: Øyvind Harboe <oyvind.harboe@zylin.com>
 2010-03-20 11:16:49 +01:00
Øyvind Harboe
7f6bab0c4c jtag: retire jtag_get/set_end_state() 
Voila! This get rids of mysteries about what what
state the TAP is in.

Signed-off-by: Øyvind Harboe <oyvind.harboe@zylin.com>
 2010-03-19 08:31:44 +01:00
Øyvind Harboe
36df240cea jtag: cut down on usage of unintended modification of global end state 
jtag_get/set_end_state() is now deprecated.

There were lots of places in the code where the end state was
unintentionally modified.

The big Q is whether there were any places where the intention
was to modify the end state. 0.5 is a long way off, so we'll
get a fair amount of testing.

Signed-off-by: Øyvind Harboe <oyvind.harboe@zylin.com>
 2010-03-18 08:43:19 +01:00
Øyvind Harboe
57d7743639 jtag: jtag_add_ir_scan() now takes a single field 
In the code a single field was all that was ever used. Makes
jtag_add_ir_scan() simpler and leaves more complicated stuff
to jtag_add_plain_ir_scan().

Signed-off-by: Øyvind Harboe <oyvind.harboe@zylin.com>
 2010-03-08 08:12:25 +01:00
Øyvind Harboe
e018c7c1d2 jtag: retire tap field 
jtag_add_dr/ir_scan() now takes the tap as the first
argument, rather than for each of the fields passed
in.

The code never exercised the path where there was
more than one tap being scanned, who knows if it even
worked.

This simplifies the implementation and reduces clutter
in the calling code.

use jtag_add_ir/dr_plain_scan() for more fancy situations.

Signed-off-by: Øyvind Harboe <oyvind.harboe@zylin.com>
 2010-03-08 08:12:25 +01:00
David Brownell
973cd9a299 PLD: usage/help updates 
Make "usage" messages use the same EBNF as the User's Guide;
no angle brackets.  Improve and correct various helptexts.

Don't use "&function"; a function's name is its address.
Remove a couple instances of pointless whitespace, shrink
a few overlong lines.

Signed-off-by: David Brownell <dbrownell@users.sourceforge.net>
 2010-01-08 23:23:55 -08:00
Øyvind Harboe
eb1bc657ae build: add build/src to include path 
This allows including generated include files.

Signed-off-by: Øyvind Harboe <oyvind.harboe@zylin.com>
 2009-12-08 10:16:10 +01:00
Zachary T Welch
822c06d9e3 remove tertiary include paths 
With all #include directives converted, we only need to have the
top-level src/ directory in the search path.
 2009-12-03 04:24:50 -08:00
Zachary T Welch
cb4a475f6c change #include "jtag.h" to <jtag/jtag.h> 
Changes from the flat namespace to heirarchical one.  Instead of writing:

	#include "jtag.h"

the following form should be used.

	#include <jtag/jtag.h>

The exception is from .c files in the same directory.
 2009-12-03 04:24:33 -08:00
Zachary T Welch
df0e90ec8c change #include "types.h" to <helper/types.h> 
Changes from the flat namespace to heirarchical one.  Instead of writing:

	#include "types.h"

the following form should be used.

	#include <helper/types.h>

The exception is from .c files in the same directory.
 2009-12-03 04:22:52 -08:00
Zachary T Welch
6512e5e36b change #include "time_support.h" to <helper/time_support.h> 
Changes from the flat namespace to heirarchical one.  Instead of writing:

	#include "time_support.h"

the following form should be used.

	#include <helper/time_support.h>

The exception is from .c files in the same directory.
 2009-12-03 04:22:52 -08:00
Zachary T Welch
c79cca04be change #include "log.h" to <helper/log.h> 
Changes from the flat namespace to heirarchical one.  Instead of writing:

	#include "log.h"

the following form should be used.

	#include <helper/log.h>

The exception is from .c files in the same directory.
 2009-12-03 04:22:52 -08:00
Zachary T Welch
264d24495d change #include "command.h" to <helper/command.h> 
Changes from the flat namespace to heirarchical one.  Instead of writing:

	#include "command.h"

the following form should be used.

	#include <helper/command.h>

The exception is from .c files in the same directory.
 2009-12-03 04:22:48 -08:00
Zachary T Welch
896ac8d4ef allow #include directives to use module name 
Includes the src directory in the search path, so header files may be
migrated from:

  #include "foo.h"

to
  #include <module/foo.h>

which is more conducive for installation.
 2009-12-03 01:54:15 -08:00
Zachary T Welch
682910fdc2 pld: factor init to 'pld init' 
Split PLD initialization into 'pld init', which gets called from 'init'.
 2009-12-02 13:26:22 -08:00
Zachary T Welch
e2f23c5437 pld: use static registration instead of callback 
Remove register_callbacks from pld_device structure, using an array
of command_registration records instead.
 2009-11-24 21:37:33 -08:00
Zachary T Welch
76b89755c9 pld: use register_commands() 
Updates core PLD and virtex2 commands to use register_commands().
 2009-11-24 21:37:33 -08:00
Zachary T Welch
833e7f5248 use COMMAND_REGISTER macro 
Replaces direct calls to register_command() with a macro, to allow
its parameters to be changed and callers updated in phases.
 2009-11-24 21:37:29 -08:00
Zachary T Welch
2861877b32 command_handler: change 'cmd_ctx' to CMD_CTX 
Convert all command handler 'cmd_ctx' parameter usage with CMD_CTX.
 2009-11-17 11:40:06 -08:00
Zachary T Welch
23402315ce command_handler: change 'args' to CMD_ARGV 
This patch converts all instances of 'args' in COMMAND_HANDLER routines
to use CMD_ARGV macro.
 2009-11-17 11:38:07 -08:00
Zachary T Welch
7bf1a86e47 command_handler: change to 'argc' to CMD_ARGC 
This patch converts all instances of 'argc' in COMMAND_HANDLER routines
to use CMD_ARGC.
 2009-11-17 11:38:06 -08:00
Zachary T Welch
a94748ec6d rename CEIL as DIV_ROUND_UP 
Improves the name of this macro, moves it to types.h, and adds a block
of Doxygen comments to describe what it does.
 2009-11-16 09:58:11 -08:00
Zachary T Welch
ef746e27c5 command_t -> struct command 
Remove misleading typedef and redundant suffix from struct command.
 2009-11-13 13:30:50 -08:00
Zachary T Welch
98723c4ecd command_context_t -> struct command_context 
Remove misleading typedef and redundant suffix from struct command_context.
 2009-11-13 13:25:47 -08:00
Zachary T Welch
95bf461c0a pld_device_t -> struct pld_device 
Remove misleading typedef and redundant suffix from struct pld_device.
 2009-11-13 11:58:08 -08:00
Zachary T Welch
db08ab8a79 virtex2_pld_device_t -> struct virtex2_pld_device 
Remove misleading typedef and redundant suffix from struct virtex2_pld_device.
 2009-11-13 11:58:08 -08:00
Zachary T Welch
cd4c059806 xilinx_bit_file_t -> struct xilinx_bit_file 
Remove misleading typedef and redundant suffix from struct xilinx_bit_file.
 2009-11-13 11:58:08 -08:00
Zachary T Welch
db2086897a pld_driver_t -> struct pld_driver 
Remove misleading typedef and redundant suffix from struct pld_driver.
 2009-11-13 11:58:08 -08:00
Zachary T Welch
d0809ac060 scan_field_t -> struct scan_field 
Remove useless structure typedef.
 2009-11-13 11:58:04 -08:00
Zachary T Welch
42ef503d37 jtag_tap_t -> struct jtag_tap 
Search and destroy the jtag_tap_t typedef.  This also cleans up a
layering violation, removing the declaration from types.h.
 2009-11-13 11:58:04 -08:00
Zachary T Welch
5b6df55a1e use CALL_COMMAND_HANDLER instead of direct calls 
By using CALL_COMMAND_HANDLER, parameters can be reordered, added, or
even removed in inherited signatures, without requiring revisiting
all of the various call sites.
 2009-11-13 10:51:46 -08:00
Zachary T Welch
1df5cc18f5 add PLD_DEVICE_COMMAND_HANDLER macro 
Update virtex module to use abstracted PLD command handling.
 2009-11-13 10:51:46 -08:00
Zachary T Welch
cfc4d5c6b7 use COMMAND_HANDLER macro to define all commands 2009-11-13 10:51:45 -08:00
Zachary T Welch
39ab1c1a41 remove more useless declarations 
Removes forward declarations by moving command registration after
defintion of the command handlers.
 2009-11-11 11:53:22 -08:00
Zachary T Welch
ca594adb5a add const keyword to some APIs 
Add 'const' keyword to 'char *' parameters to allow command handlers to
pass constant string arguments.  These changes allow the 'args' command
handler to be changed to 'const' in a subsequent patch.
 2009-11-11 11:53:22 -08:00
Zachary T Welch
994a63c3fe src/{server,pld,svf,xsvf}: remove 'extern' keyword 
Removes 'extern' keyword from function declarations in header filess.
 2009-11-09 09:44:33 -08:00
Zachary T Welch
6e542407e7 Improve pld command argument parsing. 2009-11-05 18:03:19 -08:00
zwelch
c493543fc9 - Replace '){' with ') {'. 
git-svn-id: svn://svn.berlios.de/openocd/trunk@2378 b42882b7-edfa-0310-969c-e2dbd0fdcd60
 2009-06-23 22:49:06 +00:00
zwelch
dc575dc5bf Remove whitespace that occurs before ')'. 
- Replace '[ \t]*[)]' with ')'.


git-svn-id: svn://svn.berlios.de/openocd/trunk@2377 b42882b7-edfa-0310-969c-e2dbd0fdcd60
 2009-06-23 22:47:42 +00:00
zwelch
f90d8fa45f Remove whitespace that occurs after '('. 
- Replace '([ \t]*' with '('.


git-svn-id: svn://svn.berlios.de/openocd/trunk@2376 b42882b7-edfa-0310-969c-e2dbd0fdcd60
 2009-06-23 22:46:23 +00:00
zwelch
84df52f9ea - Fixes '=' whitespace 
- Replace ')\(=\)\(\w\)' with ') \1 \2'.
- Replace '\(\w\)\(=\)(' with '\1 \2 ('.
- Replace '\(\w\)\(=\)\(\w\)' with '\1 \2 \3'.


git-svn-id: svn://svn.berlios.de/openocd/trunk@2372 b42882b7-edfa-0310-969c-e2dbd0fdcd60
 2009-06-23 22:42:54 +00:00