forked from auracaster/openocd
e10fb1e2a4
The buffer size check was using len + 4 but snprintf requires additional space for the null terminator. The snprintf call formats '#%02x' which needs 4 bytes total (1 for '#', 2 for checksum, 1 for null terminator). The original check of len + 4 was insufficient and could cause snprintf to truncate the checksum and replace the last character with '\0', leading to malformed GDB packets. Fix by changing the buffer size check from len + 4 to len + 5 (1 for '$', 1 for '#', 2 for checksum, 1 for null terminator) to provide adequate space for snprintf's null terminator. Change-Id: Ibf8b3c3f5e4d5ac5be795b8e688e055453798afe Signed-off-by: Ryan QIAN <jianghao.qian@hpmicro.com> Reviewed-on: https://review.openocd.org/c/openocd/+/9117 Tested-by: jenkins Reviewed-by: Tomas Vanek <vanekt@fbl.cz>