auracaster/sw_pyalsaaudio
3
0
Fork 0
forked from auracaster/pyalsaaudio
Code Pull Requests Activity

fix deprecation warning about PyUnicode_AsUnicode()

Browse Source 
converting to ascii for the purpose of comparison is inefficient.
This commit is contained in:
Oswald Buddenhagen
2022-08-07 13:15:38 +02:00
parent 4318b63912
commit 9dc0fc2fd3
1 changed files with 7 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files
alsaaudio.c
+7
View File
@@ -179,11 +179,18 @@ get_pcmtype(PyObject *obj)
#endif #endif
if (PyUnicode_Check(obj)) { if (PyUnicode_Check(obj)) {
#if PY_MAJOR_VERSION > 2
if (PyUnicode_CompareWithASCIIString(obj, "playback") == 0)
return SND_PCM_STREAM_PLAYBACK;
else if (PyUnicode_CompareWithASCIIString(obj, "capture") == 0)
return SND_PCM_STREAM_CAPTURE;
#else
const char *dirstr = PyUnicode_AS_DATA(obj); const char *dirstr = PyUnicode_AS_DATA(obj);
if (strcasecmp(dirstr, "playback")==0) if (strcasecmp(dirstr, "playback")==0)
return SND_PCM_STREAM_PLAYBACK; return SND_PCM_STREAM_PLAYBACK;
else if (strcasecmp(dirstr, "capture")==0) else if (strcasecmp(dirstr, "capture")==0)
return SND_PCM_STREAM_CAPTURE; return SND_PCM_STREAM_CAPTURE;
#endif
} }
PyErr_SetString(ALSAAudioError, "PCM type must be PCM_PLAYBACK (0) " PyErr_SetString(ALSAAudioError, "PCM type must be PCM_PLAYBACK (0) "