auracaster/sw_pyalsaaudio
3
0
Fork 0
forked from auracaster/pyalsaaudio
Code Pull Requests Activity

Use correct sample bit width

Browse Source 
snd_pcm_hw_params_get_sbits gives the number of significant bits, not
the actual number of bits stored. Change to snd_pcm_format_physical_width.

This fixes a bug where, for example on my hardware:
format = 'S32_LE'
significant bits = 24
physical bits = 32

the program will segfault because the allocated buffer is too small.
This commit is contained in:
Ville Viinikka
2024-02-13 23:12:17 +02:00
committed by Lars Immisch
parent 0aba948277
commit eda913b203
1 changed files with 1 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
alsaaudio.c
View File

@@ -403,7 +403,7 @@ static int alsapcm_setup(alsapcm_t *self)
snd_pcm_hw_params_get_period_size(hwparams, &self->periodsize, &dir);
snd_pcm_hw_params_get_periods(hwparams, &self->periods, &dir);
self->framesize = self->channels * snd_pcm_hw_params_get_sbits(hwparams)/8;
self->framesize = self->channels * snd_pcm_format_physical_width(self->format)/8;
return res;
}