From 9023407ee4a7425e1f5bda1e78c62e59524c4c08 Mon Sep 17 00:00:00 2001 From: Markus Jellitsch Date: Thu, 23 Jan 2025 15:14:54 +0100 Subject: [PATCH 1/5] fix advertising parameters for legacy advertising --- bumble/device.py | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/bumble/device.py b/bumble/device.py index 1a6d7547..998691b8 100644 --- a/bumble/device.py +++ b/bumble/device.py @@ -380,8 +380,8 @@ class LegacyAdvertiser: # Set the advertising parameters await self.device.send_command( hci.HCI_LE_Set_Advertising_Parameters_Command( - advertising_interval_min=self.device.advertising_interval_min, - advertising_interval_max=self.device.advertising_interval_max, + advertising_interval_min=int(self.device.advertising_interval_min / 0.625), + advertising_interval_max=int(self.device.advertising_interval_max / 0.625), advertising_type=int(self.advertising_type), own_address_type=self.own_address_type, peer_address_type=self.peer_address.address_type, @@ -2583,8 +2583,8 @@ class Device(CompositeEventEmitter): auto_restart: bool = False, advertising_data: Optional[bytes] = None, scan_response_data: Optional[bytes] = None, - advertising_interval_min: Optional[int] = None, - advertising_interval_max: Optional[int] = None, + advertising_interval_min: Optional[float] = None, + advertising_interval_max: Optional[float] = None, ) -> None: """Start legacy advertising. From 180655088c5a4a0ea85b611eeb6e30e5ad303cac Mon Sep 17 00:00:00 2001 From: Markus Jellitsch Date: Mon, 27 Jan 2025 22:17:31 +0100 Subject: [PATCH 2/5] run linter --- bumble/device.py | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/bumble/device.py b/bumble/device.py index 998691b8..8f678388 100644 --- a/bumble/device.py +++ b/bumble/device.py @@ -380,8 +380,12 @@ class LegacyAdvertiser: # Set the advertising parameters await self.device.send_command( hci.HCI_LE_Set_Advertising_Parameters_Command( - advertising_interval_min=int(self.device.advertising_interval_min / 0.625), - advertising_interval_max=int(self.device.advertising_interval_max / 0.625), + advertising_interval_min=int( + self.device.advertising_interval_min / 0.625 + ), + advertising_interval_max=int( + self.device.advertising_interval_max / 0.625 + ), advertising_type=int(self.advertising_type), own_address_type=self.own_address_type, peer_address_type=self.peer_address.address_type, From b9d35aea4792cf1b4460be7e2e3393aee2c4d714 Mon Sep 17 00:00:00 2001 From: markus Date: Thu, 30 Jan 2025 19:47:20 +0100 Subject: [PATCH 3/5] revert advertising_interval to type int --- bumble/device.py | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/bumble/device.py b/bumble/device.py index 8f678388..5a2053f9 100644 --- a/bumble/device.py +++ b/bumble/device.py @@ -2587,8 +2587,8 @@ class Device(CompositeEventEmitter): auto_restart: bool = False, advertising_data: Optional[bytes] = None, scan_response_data: Optional[bytes] = None, - advertising_interval_min: Optional[float] = None, - advertising_interval_max: Optional[float] = None, + advertising_interval_min: Optional[int] = None, + advertising_interval_max: Optional[int] = None, ) -> None: """Start legacy advertising. From 01cce3525fea281ed41b89745c25129e70a6e050 Mon Sep 17 00:00:00 2001 From: markus Date: Thu, 30 Jan 2025 23:55:15 +0100 Subject: [PATCH 4/5] update avatar to github actions v4 --- .github/workflows/python-avatar.yml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/workflows/python-avatar.yml b/.github/workflows/python-avatar.yml index 082c151d..08da3489 100644 --- a/.github/workflows/python-avatar.yml +++ b/.github/workflows/python-avatar.yml @@ -44,7 +44,7 @@ jobs: run: cat rootcanal.log - name: Upload Mobly logs if: always() - uses: actions/upload-artifact@v3 + uses: actions/upload-artifact@v4 with: - name: mobly-logs + name: mobly-logs-${{ matrix.runs-on }} path: /tmp/logs/mobly/bumble.bumbles/ From 9b485fd94317ecfe68b0155aef15d703370093ce Mon Sep 17 00:00:00 2001 From: markus Date: Mon, 3 Feb 2025 15:17:22 +0100 Subject: [PATCH 5/5] revert python-avatar.yml --- .github/workflows/python-avatar.yml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/workflows/python-avatar.yml b/.github/workflows/python-avatar.yml index 08da3489..082c151d 100644 --- a/.github/workflows/python-avatar.yml +++ b/.github/workflows/python-avatar.yml @@ -44,7 +44,7 @@ jobs: run: cat rootcanal.log - name: Upload Mobly logs if: always() - uses: actions/upload-artifact@v4 + uses: actions/upload-artifact@v3 with: - name: mobly-logs-${{ matrix.runs-on }} + name: mobly-logs path: /tmp/logs/mobly/bumble.bumbles/