address PR comments

This commit is contained in:
Gilles Boccon-Gibod
2025-02-22 12:38:40 -08:00
parent 4befc5bbae
commit 82d825071c

View File

@@ -885,9 +885,7 @@ class Attribute(EventEmitter, Generic[_T]):
) )
value: Union[_T, None] value: Union[_T, None]
if self.value is None: if isinstance(self.value, AttributeValue):
value = None
elif hasattr(self.value, 'read'):
try: try:
read_value = self.value.read(connection) read_value = self.value.read(connection)
if inspect.isawaitable(read_value): if inspect.isawaitable(read_value):
@@ -930,7 +928,7 @@ class Attribute(EventEmitter, Generic[_T]):
decoded_value = self.decode_value(value) decoded_value = self.decode_value(value)
if self.value is not None and hasattr(self.value, 'write'): if isinstance(self.value, AttributeValue):
try: try:
result = self.value.write(connection, decoded_value) result = self.value.write(connection, decoded_value)
if inspect.isawaitable(result): if inspect.isawaitable(result):