auracaster/openocd
3
0
Fork 1
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

pld/gatemate: move pointer deref after NULL check

Browse Source 
Move pointer deref after NULL check.
Found by cppcheck.

Change-Id: Ifdf40046cb1b03dbe7f445660b3349deae788e7b
Signed-off-by: Mark O'Donovan <shiftee@posteo.net>
Reviewed-on: https://review.openocd.org/c/openocd/+/9499
Reviewed-by: Daniel Anselmi <danselmi@gmx.ch>
Reviewed-by: Antonio Borneo <borneo.antonio@gmail.com>
Tested-by: jenkins
This commit is contained in:
Mark O'Donovan
2026-02-24 20:44:43 +00:00
committed by Antonio Borneo
parent b215fe8621
commit 0e41ac862d
1 changed files with 2 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
src/pld/gatemate.c
View File

@@ -138,11 +138,11 @@ static int gatemate_read_cfg_file(struct gatemate_bit_file *bit_file, const char
static int gatemate_read_file(struct gatemate_bit_file *bit_file, const char *filename) static int gatemate_read_file(struct gatemate_bit_file *bit_file, const char *filename)
{ {
memset(bit_file, 0, sizeof(struct gatemate_bit_file));
if (!filename || !bit_file) if (!filename || !bit_file)
return ERROR_COMMAND_SYNTAX_ERROR; return ERROR_COMMAND_SYNTAX_ERROR;
memset(bit_file, 0, sizeof(struct gatemate_bit_file));
/* check if binary .bit or ascii .cfg */ /* check if binary .bit or ascii .cfg */
const char *file_suffix_pos = strrchr(filename, '.'); const char *file_suffix_pos = strrchr(filename, '.');
if (!file_suffix_pos) { if (!file_suffix_pos) {