auracaster/openocd
3
0
Fork 1
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

target/riscv: return ERROR_TARGET_NOT_HALTED

Browse Source 
instead of ERROR_FAIL where appropriate.

Change-Id: I1881c0c6c437355007c3844556489162666023dc
Signed-off-by: Tomas Vanek <vanekt@fbl.cz>
Reviewed-on: https://review.openocd.org/c/openocd/+/9171
Tested-by: jenkins
Reviewed-by: Evgeniy Naydanov <evgeniy.naydanov@syntacore.com>
This commit is contained in:
Tomas Vanek
2025-10-14 15:29:55 +02:00
parent 6d764f5b09
commit f354d259ff
2 changed files with 5 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
src/target/riscv/riscv-013.c
View File

@@ -2323,7 +2323,7 @@ static int prep_for_vector_access(struct target *target,
if (target->state != TARGET_HALTED) {
LOG_TARGET_ERROR(target,
"Unable to access vector register: target not halted");
return ERROR_FAIL;
return ERROR_TARGET_NOT_HALTED;
}
if (prep_for_register_access(target, orig_mstatus, GDB_REGNO_VL) != ERROR_OK)
return ERROR_FAIL;
@@ -5476,7 +5476,7 @@ static int riscv013_step_or_resume_current_hart(struct target *target,
{
if (target->state != TARGET_HALTED) {
LOG_TARGET_ERROR(target, "Hart is not halted!");
return ERROR_FAIL;
return ERROR_TARGET_NOT_HALTED;
}
LOG_TARGET_DEBUG(target, "resuming (operation=%s)",

6
src/target/riscv/riscv.c
View File

@@ -5425,7 +5425,7 @@ COMMAND_HANDLER(riscv_exec_progbuf)
if (target->state != TARGET_HALTED) {
LOG_TARGET_ERROR(target, "exec_progbuf: Can't execute "
"program buffer, target not halted.");
return ERROR_FAIL;
return ERROR_TARGET_NOT_HALTED;
}
if (riscv_progbuf_size(target) == 0) {
@@ -6039,7 +6039,7 @@ static int riscv_step_rtos_hart(struct target *target)
if (target->state != TARGET_HALTED) {
LOG_TARGET_ERROR(target, "Hart isn't halted before single step!");
return ERROR_FAIL;
return ERROR_TARGET_NOT_HALTED;
}
r->on_step(target);
if (r->step_current_hart(target) != ERROR_OK)
@@ -6229,7 +6229,7 @@ int riscv_enumerate_triggers(struct target *target)
if (target->state != TARGET_HALTED) {
LOG_TARGET_ERROR(target, "Unable to enumerate triggers: target not halted.");
return ERROR_FAIL;
return ERROR_TARGET_NOT_HALTED;
}
riscv_reg_t orig_tselect;