auracaster/sw_openocd
3
0
Fork 0
forked from auracaster/openocd
Code Pull Requests Activity

target: openrisc: jsp_server: check for out of memory, fix memory leak

Browse Source 
During JSP service start, check that memory is properly allocated
and if add_service() fails release the allocated memory.

Change-Id: I7eb2ea8a10dbeccd27fd39485080552c5d0736d3
Signed-off-by: Antonio Borneo <borneo.antonio@gmail.com>
Reviewed-on: https://review.openocd.org/c/openocd/+/9375
Tested-by: jenkins
Reviewed-by: Tomas Vanek <vanekt@fbl.cz>
This commit is contained in:
Antonio Borneo
2026-01-04 17:43:31 +01:00
parent b10372f0d2
commit 00e4fb653d
1 changed files with 10 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

11
src/target/openrisc/jsp_server.c
View File

@@ -195,10 +195,19 @@ static const struct service_driver jsp_service_driver = {
int jsp_init(struct or1k_jtag *jtag_info, char *banner)
{
struct jsp_service *jsp_service = malloc(sizeof(struct jsp_service));
if (!jsp_service) {
LOG_ERROR("Out of memory");
return ERROR_FAIL;
}
jsp_service->banner = banner;
jsp_service->jtag_info = jtag_info;
return add_service(&jsp_service_driver, jsp_port, 1, jsp_service);
int retval = add_service(&jsp_service_driver, jsp_port, 1, jsp_service);
if (retval != ERROR_OK)
free(jsp_service);
return retval;
}
COMMAND_HANDLER(handle_jsp_port_command)