in principle, the state is already available from info(), but that's a
rather heavy function for something one might want to query often.
a practical use case might be checking whether a playback stream is done
draining, for example.
for playback, this allows making sure that all written frames are
played, without using an external delay.
in principle, it's also usable for capture, but there isn't really a
practical reason to do so, as simply discarding excess captured frames
has no real cost.
the period count is just as important for playback latency as the period
size, so it makes no sense to have only one of them configurable.
as a drive-by, fix up the handling of periods in info() & dumpinfo().
perform it prior to invoking read()/write() if necessary, not right
after a failure event. this makes things more uniform and predictable.
we don't use snd_pcm_recover() any more, as we used it only for the
EPIPE case anyway, which boils down to snd_pcm_prepare() exactly.
handling ESTRPIPE as well might be desirable, but that's a separate
consideration.
this removes lots of casts around snd_pcm_hw_params_get_*() calls
we could go further with that to make the code clean if we enabled all
the warnings, but it doesn't seem worth the effort.
it's been obsolete for a *long* time, and having it redundantly to the
rst sources is bad hygiene. it still contained some useful info, which
has been transplanted to the rst source in the previous commit.
for clarity, this includes docs which were previously omitted
(presumably) intentionally, but mark them as comments.
the getrec() and getmute() functions' docs are moved around, so they
appear in pairs with their set*() counterparts, like the *volume() ones
already did.
notably, this also fixes the docu of PCM_FORMAT_U8, which closes#104.
mention xruns, and rework the definition of periods: concentrate on
relevant information, and remove the misinformation about period size
reduction being not that bad (pedantically, an application could run
somewhat asynchronously to the interrupts by using some timer, and
therefore actually save some of the overhead, but why would one use a
small period size in the first place then?).
also, language and formatting fixes.
in case of error, alsamixer_new() would leak the object, while
alsamixer_list() might crash due to a null pointer.
as a drive-by, make alsamixer_gethandle() `static`.
commit 8abf06be introduced a pause() prior to draining, in an attempt
to work around clearly broken pulseaudio client behavior for capture
streams (drain() is supposed to imply a stop).
but as the workaround was also applied to playback streams, it would
cause nasty "clicks", as the stream would (obviously) stop before being
resumed for draining.
but draining is actually pointless for capture streams, as we're closing
right afterwards, so the samples are lost anyway.
what's more, destructors are not supposed to wait for anything, so
draining in alsapcm_dealloc() was wrong to start with. so we remove it.
note that this is a minor behavior change, which is reflected by the
adjustment of the playback test to have an explicit close() at the end.
finally, close() was also affected by the pulseaudio bug (which was not
addressed before), so there we make draining exclusive to playback
streams.
* First version documentation PCM.info() method.
* Add reference to documentation to docstring for PCM.info() method.
* Add extra fields to info dict:
card_no *index of card* integer (negative indicates device not associable with a card)
device_no *index of PCM device* integer
subdevice_no *index of PCM subdevice* integer
and update documentation accordingly.
Co-authored-by: Ronald van Elburg <Ronald@SoundAppraisal.eu>
* alsamixer_getvolume: Fix incorrect parenthesis
The pcmtypeobj check is overriding the pcmtype if the object is not NULL
or Py_None, making it impossible to get the playback volume. Fix the
paranthesis so that pcmtype is only overwritten when pcmtypeobj is not
set.
* Fix indentation format
Fix the indentation format to match the rest of the project.1
Co-authored-by: Portia <portia.stephens@biamp.com>
* Use `pcmtype` keyword for range
Update methods that accept a `direction` argument (i.e.
capture/playback) to get this via positional _or_ keyword arguments.
Code using keyword arguments can be more robust; however the main reason
for this change is to prepare the way for an extra `units` argument to
many of these methods.
Update documentation to consistently use `pcmtype` instead of
a mixture of that and `direction`.
* Support units